Some other modes leave the task surface in a bad state, so if
fullscreen gets onTaskAppeared, reset everything to fullscreen
Bug: 168278812
Test: Open an app, put it into pip, close pip by dragging to X,
open the app from recents.
Change-Id: Icf4df30eb44fa0a589e7d0bd9be1eb2e72fc492a
Fix a bug where taskinfo changes weren't recording the
changes.
Add FullscreenTaskListener which is very basic and just
shows surfaces on appear. Fullscreen works fine with
this much because the surfaces are always at 0,0
anyways.
Bug: 162499076
Test: Existing tests pass, phone works like normal
Change-Id: I606bc1cbc85c33c4fc40baf6b3080a1eaa37550c
The frame won't be changed if there is no IWindow#resized or
IWindowSession#relayout. So it can be retrieved from these methods
directly instead of another binder transaction.
And because some parameters are usually used together for layout,
the parameters are consolidated into a new ClientWindowFrames.
That reduces changing the interface in the future if the frame
related information needs to be changed.
Also refine the resize handling in ViewRootImpl to make it easier
to read.
There should be no behavior change by this modification.
Bug: 161781274
Test: WmTests, DialogFrameTests
Change-Id: I9f711ad2023442046fa8582944320b98e7c4ecfa
Move OneHanded related codes, res and tests to WM shell.
Some tests add ignored currently due to permission issue.
Add another bug to trace it.
Also fix animation issue caused by wrong logic.
Bug: 161980408
Fix: 168074363
Test: manual check one handed function
Test: atest WMShellUnitTests
Test: atest SystemUITests
Test: make ArcSystemUI; make ArcSystemUITests
Test: make CarSystemUI; make CarSystemUITests
Change-Id: Ib25661d010278202ffe15fd9c4962e76e6698c21
This is to allow unit test against TaskOrganizer, WindowOrganizer for
interations between Shell and WM core.
To test on WM side
```
when(mWindowOrganizer.getWindowOrganizerController())
.thenReturn(mockedWindowOrganizerController);
when(mockedWindowOrganizerController.getTaskOrganizerController())
.thenReturn(mockedTaskOrganizerController)
doSomeTest();
verify(mockedWindowOrganizerController).somethingHappended();
verify(mockedTaskOrganizerController).somethingHappended();
```
To test on Shell side
```
ShellTaskOrganizer organizer = new ShellTaskOrganizer(
mockedTaskOrganizerController)
doSomeTest()
verify(mockedTaskOrganizerController).somethingHappended();
```
Removed also
- Singleton pattern in TaskOrganizer and DisplayAreaOrganizer as it's
redundant to what's in WindowOrganizer
- static getController methods in both TaskOrganizer and
DisplayAreaOrganizer as we prefer non-static for testability
- static methods in TaskOrganizer in general
- static methods in WindowManagerProxy in general
Bug: 161711455
Bug: 149338177
Test: make sure everything still works
Test: atest WmTests:WindowOrganizerTests \
WmTests:DisplayAreaOrganizerTest
Change-Id: I978d20c7b87e73d0f6d22f7ab08188e4d12d745c
Previously the flickerlib had some pixel specific code, now it's
general. All pixel specific code either should migrate to FlickerTests
or to flickerlib-helpers
Test: atest FlickerTests
Change-Id: Ibca99f2bf68a511f73130439f6334a01e47a8671
Moves FlingAnimationUtils to wm shell library as a common utils for both
wm shell and SystemUI.
There are some basic interpolators needed for wm shell library. Since
they are relative basic and already been put into different packages,
duplicates them directly to wm shell library.
Bug: 161116823
Test: atest SystemUITests
Test: manual check divider animation
Change-Id: Iffabb7eff829cad69ef3d273b803f8fbd3ab6685
- Refactor out base protolog impl so that shell can have it's own
implementation which takes a different viewer config (from the resources
directly instead of a separate file in /system/etc)
- Setup the protolog transform for shell classes
- Add some basic protologs for displayarea/task organizer controller
& shell task org (for now only text logging)
Bug: 161980327
Test: adb shell wm logging enable-text WM_DEBUG_WINDOW_ORGANIZER
Test: adb shell dumpsys activity service SystemUIService WMShell enable-text-logging WM_SHELL_TASK_ORG
Test: atest ProtoLogImplTest \
ProtoLogViewerConfigReaderTest \
WmTests:ProtoLogIntegrationTest \
LogDataTypeTest \
protologtool-tests
Change-Id: I4c3fd6aaea04987c26ac56e9baf9fc8ab75a3f34
Signed-off-by: Winson Chung <winsonc@google.com>
Separated folders in libs/WindowManager/Shell/tests
- unittest, for unit tests
- flicker, for this flicker tests
- propose to add functional/ folder for functional tests
Note also
- Copied over EnterPipTest from existing flicker tests as proof of
concept
- TODO: need to figure out the next step for the flicker test library
itself as it's currently packaged in com.android.server.wm
Bug: 161561007
Test: atest WMShellFlickerTests
Test: atest WMShellUnitTests
Change-Id: Ic06e7cb0f98151591ccb9f5217260939349a9aa5
Removes Divider from SystemUI component list since it is no longer
needed after the split screen feature migrated to WM shell library.
Provides optional controller of split screen for sysui components to
use. Different varients of SystemUI could leverage dagger module to
decide whether to load the controller or not.
Implements WMShell component in SysUISingleton scope to help delegating
sysui specific events to WM shell controllers.
Detached DisplayImeController's initialization step from split screen
feature with the reason that some of SystemUI varients might not have
split screen feature.
Bug: 161116823
Test: atest SystemUITests
Test: atest SystemUIGoogleTests
Test: atest CarSystemUITests
Test: manual verified spliscreen behavior
Change-Id: I4220b5ce53bc7b793b95cfca34100e808b9f052c
- Create a single task organizer in SysUI which registers as an organizer
for multiple windowing modes internally in TaskOrgController.
Bug: 161980327
Test: atest WindowOrganizerTests
Test: atest SplitScreenTests
Test: atest PinnedStackTests
Test: atest ShellTaskOrganizerTests
Change-Id: Ic9dfbd6bcd75d9317e5a3aeb695afdff7e869d35
Seperate display listener registration out of constructor to prevent
circular initialization problem. Use builder to make sure
DisplayImeController and DisplaySystemBarsController will be initialized
properly.
Fix: 161963879
Bug: 161655636
Test: make CarSystemUI
Test: atest CarActivityViewDisplayIdCrashTest
Change-Id: I1104f7bc506d1194d8a2c016106647663d4d24ed
There're some classes reaching to DisplayController and IWindowService
through SystemWindows, decouple SystemWindows from these classes and
inject needed instances directly. Update to use view.getContext instead
of injecting context from SystemUI.
Bug: 161655636
Test: atest WindowManagerShellTests
Test: atest SystemUITests
Change-Id: Ic6da21d6e407d222660b86bfb0f975c4f784b7f5
This CL does:
- Add a PipMenuIconsAlgorithm, allowing calculation on the fly for
correct locations of individual icons
- Make it so that when PIP changes its bounds, it updates the location
of the action items accordingly (if needed)
Bug: 160825579
Test: enter PIP, icons are still where they are
Change-Id: I8618f7c5c36c8e09613c126c1ebb20b60e95de58
WM Shell should be compiled against the platform APIs and thus should
leave sdk version empty. The value of platform_apis will be ignored when
module's type isn't android_app, remove it as well.
Bug: 161116823
Test: manual verified it could access to @hide APIs
Test: make WindowManager-Shell
Test: atest WindowManagerShellTest
Change-Id: I145b0d6352a6e10a2f4051a561e65c282374fa7c
