am skip reason: Change-Id I22182d90b0057df67fbd6d20785da23d6c17dcf3 with SHA-1 c8048daed2 is in history
Change-Id: I0d5375b98bac66de51cfe1a5398ca591f3a31562
Once a new Request is in flight, we probably don't want to display the
old responses.
This prevents a VIEW_ENTERED flow from displaying the suggestions
(either as a dropdown or as inline chips) if there is a pending request
for the same partition. Thus fixing a bug where the suggestions may be
rendered twice - once from the VIEW_ENTERED update and again from the
Fill Request succeeding (see http://b/152620157#comment7). An example of
how this may occur:
1. User taps on a View that previously showed suggestions.
2. App manually triggers autofill, which issues a new fill request.
3. The Session is updated with VIEW_ENTERED (due to (1)).
Session#requestShowInlineSuggestionsLocked returns false because of the
pending request. The system fallsback to drawing the dropdown UI.
4. FillRequest from (2) completes. This hides the dropdown and shows
inline chips.
An alternative is to exit the VIEW_ENTERED flow when there's a pending
request for the same view. This should also fix the bug, but is no
longer necessary with the current fix. The advantage of the current
approach is that the VIEW_ENTERED update logic and the request logic are
less coupled.
Fix: 152620157
Test: manual
Test: atest android.autofillservice.cts
Change-Id: Id15887ffdf28d0a3ea32e1f68ffd81f994f93187
clearResponse=true doesn't clear the response if the `response` arg is non null.
The new behavior matches the corresponding logic for authenticated
responses above (lines 3197-3200).
This affects only 1 invoking method, replaceResponseLocked, which sets
the responses again soon after, so this change shouldn't affect any
behavior.
This change also fixes the javadoc for the method.
Bug: 152620157
Test: atest android.autofillservice.cts
Test: manual
Change-Id: I78262baa1c6c11ef7e4b3c12c2ecd3d9dd28bfd7
Also test MidiFramer
Add end-to-end test through encoder and decoder.
Add test for reserved bit in header.
Bug: 35669198
Bug: 140638458
Bug: 149927520
Test: atest BluetoothMidiTests
Change-Id: I767deab6847d2b45e01bed29f5eed3df0f0e46c0
Merged-In: I767deab6847d2b45e01bed29f5eed3df0f0e46c0
- Add AnnotationId enum stats-log-api-gen
- Rename RESET_STATE annotation to TRIGGER_STATE_RESET. Also rename the proto annotation.
Bug: 152412767
Test: stats-log-api-gen-test
Test: m statslog-framework-java-gen
Change-Id: I2c12ea0b9222ef28b8cc11ea36b272e518a96259
In *theory*, a View should always receive an ACTION_DOWN before
receiving any other touch events, but this isn't always the case in
practice. Whenever we see one of these "partial" gestures, we should
ignore it until a real one starts.
Test: manual
Bug: 146323887
Merged-In: I22182d90b0057df67fbd6d20785da23d6c17dcf3
Change-Id: I22182d90b0057df67fbd6d20785da23d6c17dcf3
(cherry picked from commit c8048daed2)
Changes:
* Check logcat instead of db to confirm each step.
* Include version invalidation.
Bug: 152443508
Bug: 148936893
Test: atest iorap-functional-tests on cuttlefish.
Change-Id: I27e8fc8705889a04cb6f38295b64a25c1aceb742
onResume, BubbleOverflowActivity lazy-updates UI theming
The stack has to collapse for the user to make theming changes, so
onResume is guaranteed to run before the user sees the overflow again.
Fixes: 148879187
Fixes: 149711636
Test: manual: toggle light/dark mode -> illustration updates
Change-Id: Iaad6c92d140e141ca9203990efc07df16cc7edf8
