Commit Graph

417503 Commits

Author SHA1 Message Date
TreeHugger Robot
335dfdec1e Merge "Correct sequencing of widget vs boot-complete broadcasts" into qt-dev 2019-06-10 23:35:20 +00:00
Mehdi Alizadeh
2407da88a7 Merge "Show notifications when default launcher changes" into qt-dev 2019-06-10 22:39:20 +00:00
Christian Wailes
5e468cf4dd Merge "Fixes two data races in USAP pool management." into qt-dev 2019-06-10 22:09:43 +00:00
Quang Luong
8e13ea659e Merge "Made AccessPoint's scan result list thread safe" into qt-dev 2019-06-10 21:37:43 +00:00
Tracy Zhou
94a1aafcaa Merge "Make PiP window visible when user launches PiP in landscape mode" into qt-dev 2019-06-10 21:22:19 +00:00
TreeHugger Robot
e64acbea8e Merge "Guard against null mFunc in PooledLambdaImpl" into qt-dev 2019-06-10 20:28:11 +00:00
Mehdi Alizadeh
dc664edb2f Show notifications when default launcher changes
Shows a notification when we have to switch away from Gesture Nav
because the new launcher doesn't support it.

Also shows another notification when previously we had to switch away
from Gesture Nav, but now the new launcher supports it.

Bug: 129532605
Test: Manual test
Change-Id: Ie954dd5dea1b45795f5c0e22ab7cc1cffde4aabe
2019-06-10 13:23:47 -07:00
TreeHugger Robot
d703395fcb Merge "Expose PermissionManager as TestApi and fix SplitPermissionInfo equality" into qt-dev 2019-06-10 20:12:57 +00:00
Andrew Solovay
b230dd4fe6 Merge "docs: Fixing broken HTML" into qt-dev 2019-06-10 18:23:40 +00:00
TreeHugger Robot
fcc4d76a97 Merge "Sharesheet - Hide direct share area for low ram devices" into qt-dev 2019-06-10 17:29:52 +00:00
Winson Chung
6c88570f25 Merge "Inject dependencies instead of fetching them" into qt-dev 2019-06-10 17:14:39 +00:00
TreeHugger Robot
3baa0b34e3 Merge "Add timeout for setPermissionGrantState" into qt-dev 2019-06-10 16:32:44 +00:00
TreeHugger Robot
503b489384 Merge "Sharesheet - Adjust timeouts and logic for direct share" into qt-dev 2019-06-10 14:46:28 +00:00
Matt Pietal
6e88b51026 Sharesheet - Hide direct share area for low ram devices
Make sure to force the item count to 0 to make sure the direct share
area stays hidden.

Bug: 134776740
Test: Low ram device, manual
Change-Id: I598752db5747b1c845495af7ae2f591488799352
2019-06-10 10:20:15 -04:00
Matt Pietal
ab73a887ef Sharesheet - Adjust timeouts and logic for direct share
Improve direct share loading by:
1. Do not issue redundant service calls within the watchdog timeout
period
2. Set a min and max watchdog timeout period, and if all services
return early, then informt the user we are done to so that they don't
have to wait until the max timeout period.
3. Be more specific on package changes. Resolver requires any change
to trigger a refresh, but chooser only needs to know about top level
package changes.

Bug: 134416594
Test: Manual
Change-Id: I075fd5b6f64c25637fd7ba7aa6b163dca81371a8
2019-06-10 07:24:51 -04:00
Santos Cordon
8a03eb7842 Merge "Ignore brightness change thresholds for manual changes." into qt-dev 2019-06-09 23:58:14 +00:00
Winson Chung
9e572495d9 Inject dependencies instead of fetching them
Bug: 134712444
Test: atest SystemUITests
Test: atest NotificationStackScrollLayoutTest (wasn't actually able to
      reproduce locally)

Change-Id: Ic1478a3eca164b844ba5721014e5591a6af02ffa
2019-06-09 10:45:34 -07:00
Bill Yi
9edd318666 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: Ida0624dfdb53a688b75bd7e03a7c02e32047ded3
2019-06-09 01:57:05 -07:00
TreeHugger Robot
4fd921518e Merge "Import translations. DO NOT MERGE" into qt-dev 2019-06-08 16:39:56 +00:00
Bill Yi
acbb8d3afd Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I415dad40c35ad89a25d4df9190742a3515764a27
2019-06-08 08:30:59 -07:00
TreeHugger Robot
12ae95987b Merge "Persist metric activation across beta4/5 ota" into qt-dev 2019-06-08 14:38:06 +00:00
TreeHugger Robot
80bbe491e4 Merge "Import translations. DO NOT MERGE" into qt-dev 2019-06-08 05:16:18 +00:00
TreeHugger Robot
47b4c6d5df Merge "Remove obsolete state" into qt-dev 2019-06-08 02:56:24 +00:00
Bill Yi
d30f731566 Import translations. DO NOT MERGE
Auto-generated-cl: translation import

Bug: 64712476
Change-Id: I8ce265c5d257e5cdbc247dc459a2432713f1c7b6
2019-06-07 19:55:35 -07:00
Lucas Dupin
e24c0bf69c Remove obsolete state
There isn't a fingerprint animation, we don't need the timeout anymore.
This event was triggering unwanted updates, cancelling animations
during wake-up.

Fixes: 134448130
Test: power to wake-up: observe animation
Test: fingerprint from bouncer: observe animation
Test: fingerprint to wake-up: no animation
Change-Id: I17fcd9eb5eba7e7bc88de09309f5c310fe13433f
Merged-In: I17fcd9eb5eba7e7bc88de09309f5c310fe13433f
2019-06-08 01:55:03 +00:00
Lucas Dupin
38d017b0d6 Merge "Do not animate status bar icons outside of shade" into qt-dev 2019-06-08 01:54:16 +00:00
Tej Singh
cbf2c64024 Persist metric activation across beta4/5 ota
In beta 4, activeEventActivation proto object does not have a state
field and assumed to be active if it is written to disk. In beta 5, we
add a state field to support persisting metric activation status across
a system server crash. However, if a device updated from beta 4 to 5, we
don't have any knowledge of the state when we read. Therefore, assume
the lack of the state field as the event activation should be active for
the provided ttl.

Bug: 134795027
Test: used flashstation to flash a device to beta 4. Then manually push
and activate a simple config. Then use vendor/google/tools/flashall to
update to qt-dev + this change. Manually ensure metric/config are still
active.
Test: gts-tradefed run gts-dev --module GtsStatsdHostTestCases
Test: bit statsd_test:*

Change-Id: I8594d04efaa2ae1f669113aaffd33e5fa5851e73
2019-06-07 17:56:24 -07:00
Christopher Tate
74e5b7dea4 Correct sequencing of widget vs boot-complete broadcasts
Past fixes to lock-management issues inadvertently altered the intended
sequencing of the widget-lifecyle and boot-completed broadcasts.  It's
correct now, with the order guaranteed by thread-of-issuance affinity.

Along the way, add the one missing bit of state reporting to the
plaintext broadcast queue dumpsys infrastructure.

Fixes: 131409711
Test: manual - boot and unlock device when widgets are being hosted by
      the home app, and observe the timings & broadcast history.

Change-Id: Iaee75d4f9f85565eab95976633460fc0abd0fa16
2019-06-07 17:55:43 -07:00
Evan Rosky
e004297aa1 Merge "Update visibility in moveTaskToBack if nothing is resumed" into qt-dev 2019-06-08 00:40:21 +00:00
Lucas Dupin
9d6172b9e2 Do not animate status bar icons outside of shade
Test: systrace
Bug: 133182504
Change-Id: Iad0b15f96d935746e16208ae875b69625ba2adfc
Merged-In: I422b3da488fdac6577173d41b26c67f81c7826c5
2019-06-07 16:36:31 -07:00
Quang Luong
3d87a9920e Merge "Unsaved carrier wifi connection should display carrier in summary" into qt-dev 2019-06-07 23:19:04 +00:00
TreeHugger Robot
e53837182c Merge "Record textAppearance information for TextView." into qt-dev 2019-06-07 22:35:55 +00:00
Amit Mahajan
be063ffb59 Merge "Avoid UnsupportedOperationException from getDefaultSmsSubscriptionId()" into qt-dev 2019-06-07 22:25:36 +00:00
Winson
f27394ee70 Expose PermissionManager as TestApi and fix SplitPermissionInfo equality
Bug: 129200416
Bug: 129200610

Test: atest SplitPermissionsTest

Change-Id: I98795944e6440e5b7ebba134bd7735a6f78ebc4f
2019-06-07 15:09:06 -07:00
TreeHugger Robot
01dbc2cbe7 Merge "Removing wtf log when crashing alarm manager client" into qt-dev 2019-06-07 21:42:31 +00:00
TreeHugger Robot
d42cb76a74 Merge changes I08c5006a,I6686b77c into qt-dev
* changes:
  Handle null OnSettingsClickListeners in ChannelDialogEditorController
  Close channel dialog when the guts go away
2019-06-07 21:36:35 +00:00
Eugene Susla
f8fc474c8f Guard against null mFunc in PooledLambdaImpl
Fixes: 134594642
Test: presubmit
Change-Id: I7b65d18df1625a276986a844569a1275c09df4e4
(cherry picked from commit 1cff0828e3)
2019-06-07 21:22:33 +00:00
TreeHugger Robot
9054ff2185 Merge "Invalidate talkback accessibility tree after transitioning" into qt-dev 2019-06-07 21:21:28 +00:00
Andrew Solovay
7ad2170f4e docs: Fixing broken HTML
A couple of broken </code> tags were messing up the formatting
for the entire page (see b/134696600 , http://screen/aThdcpoDvJo.png )

Staged the fixed doc to:

http://go/dac-stage/reference/android/app/Activity

(The live version of this doc has already been fixed -- I fixed
the HTML by hand in cl/251937759 -- but we need to fix the Java
comment, or the file will revert when we publish beta 5.)

Bug: 134696600
Test: make ds-docs (& staged HTML output)
Exempt-From-Owner-Approval: Docs-only fix
Change-Id: I7e6d11ca358d747cdc6d04741d31c7acd85aa080
2019-06-07 14:14:04 -07:00
Hongyang Jiao
3206a17e5d Merge "Whitelist START_ACTIVITIES_FROM_BACKGROUND permission for permissionController" into qt-dev 2019-06-07 21:08:02 +00:00
Quang Luong
9574a1beb4 Made AccessPoint's scan result list thread safe
If wifi verbose logging is enabled, the main thread may iterate through
the scan result list while the worker thread updates it, resulting in
an ArrayIndexOutOfBounds exception. This change adds a lock to every
iteration through mScanResults and mExtraScanResults.

Bug: 134098126
Test: atest WifiTrackerTest && atest AccessPointTest
Change-Id: If42a9ad8031ff66b1732a79772ba441185f7a18f
2019-06-07 14:06:24 -07:00
Chris Wailes
f59ea2cc39 Fixes two data races in USAP pool management.
The USAP pool management code contained two data races.  One could cause
a double decrement if a runtime thread executed the SIGCHLD handler
while the server was responding to a pool exit message from a USAP.  The
other data race could occur when the SIGCHLD handler executed in the
middle of a USAP pool flush.

The solution to the first race is to change the return value from a
helper function to ensure that the decrement only occurs when the entry
is invalidated through that specific invocation of the helper.

The second data race was fixed by using SIGTERM instead of SIGKILL when
flushing the USAP pool.  This allows the Zygote to clear the table
entries outside of the SIGCHLD handler, and the handler to avoid
duplicate bookkeeping cleanup when this occurs.  SIGTERM is used so that
it can be differentiated from other process termination events and so
that it can be blocked while the USAP is specializing, but hasn't yet
informed the Zygote of it's removal from the pool.  This issue and this
fix will no longer be necessary once the Zygote signal handler has been
replaced with a signalfd.

Bug: 132794985
Test: atest SignedConfigHostTest
Change-Id: Ie01637a10b356b80b5aa62291a97f2c167242827
Merged-In: Ie01637a10b356b80b5aa62291a97f2c167242827
(cherry picked from commit fb329ba7c8)
2019-06-07 13:32:38 -07:00
Evan Laird
0e5378e613 Handle null OnSettingsClickListeners in ChannelDialogEditorController
The property was already nullable, but prepareDialogForApp() didn't
accept a null click listener.

Test: atest ChannelDialogEditorControllerTest
Fixes: 134697988
Change-Id: I08c5006ac5519f2baa0df1a5ad29d6802c63fb3c
2019-06-07 16:12:06 -04:00
Eugene Susla
fa5fb1f661 Add timeout for setPermissionGrantState
Fixes: 134380096
Test: presubmit
Change-Id: Ifff243068eea2637cf8f6391b52a4c53bc544615
2019-06-07 12:56:47 -07:00
Quang Luong
4c23e8cbfb Unsaved carrier wifi connection should display carrier in summary
Autoconnected carrier wifi should display "Connected via <carrier>"
in the wifi picker even if the network has not been saved.

Bug: 134525097
Test: atest AccessPointTest
Change-Id: Id28daec3f80124f5329386ef5ff2b32cda505355
2019-06-07 12:04:25 -07:00
Evan Laird
b8c5103d4c Invalidate talkback accessibility tree after transitioning
Using AutoTransition seems to allow the talkback accessibility nodes to
stay out of sync if the user starts iterating the view during the
transition. Calling `notifySubtreeAccessibilityStateChangedIfNeeded()`
on the end of the transition gets us back into the correct state.

Test: manual; start iterating view via talkback swiping while the
channel dialog editor transitions between app notifications on/off
Fixes: 133822221

Change-Id: I7218bc0734cf05372b8fbecfb6eeef69cb3f1d40
2019-06-07 15:03:06 -04:00
TreeHugger Robot
d07bcd4b0d Merge "Import translations. DO NOT MERGE" into qt-dev 2019-06-07 19:01:37 +00:00
TreeHugger Robot
76de5167ab Merge "Restore WATCH_APPOPS permission for systemui" into qt-dev 2019-06-07 18:46:47 +00:00
jiaohy
0999f93e4a Whitelist START_ACTIVITIES_FROM_BACKGROUND permission for
permissionController

Bug:134429397
Test: Locally flash on sailfish
Change-Id: I650c08a7f0a823085e0eaa0e1cae8b5b44cabd8f
2019-06-07 11:46:00 -07:00
TreeHugger Robot
5cb8996742 Merge "Resetting widget cache when some configurations change" into qt-dev 2019-06-07 18:28:35 +00:00