Commit Graph

19650 Commits

Author SHA1 Message Date
TreeHugger Robot
92e8a28c74 Merge "Reduce DPAD navigation logspam with killable IME" 2022-11-14 11:54:42 +00:00
Gaurav Bhola
14fed442be Merge "Add the systemOverlays() method" 2022-11-12 22:50:29 +00:00
Tiger Huang
d548304ed6 Merge "Refine the naming about compatible scale" 2022-11-12 15:05:39 +00:00
Zeyin Wu
f1caff72f0 Merge "Add Accessibility API for rate-limiting CONTENT_CHANGE_TYPE* events" 2022-11-12 03:42:32 +00:00
Tiger
bcbd60c45c Refine the naming about compatible scale
There can be 2 reasons that we need to apply compatible scale to a
window:

1. The app doesn't support large screen. We would layout the window as
   if it is on a small display. And then we need to scale its window up
   to match the display.

2. We put a running app into a container that the size doesn't fit. We
   need to down-scale the app so that it can fit the container.

The scaling of case 2 is also known as size-compat-scale which is fully
controlled at the server side. The client shouldn't know about it. And
this CL refines the naming.

Fix: 258393096
Bug: 254187021
Test: presubmit
Change-Id: Ifbd2ca725bed231d9e6dd8190df3dc773d4402b7
2022-11-11 11:19:06 +00:00
Pascal Mütschard
581fdec050 Merge changes from topic "revert-20313761-IME tracking - hide-HZXGDCCPOZ"
* changes:
  Revert "Input latency & reliability tracking"
  Revert "Input latency & reliability tracking - hide flow"
2022-11-10 13:22:35 +00:00
Pascal Mütschard
1f4fd2d21e Revert "Input latency & reliability tracking"
Revert submission 20313761-IME tracking - hide

Bug: b/258637227
Reason for revert: Breaks CtsSystemApiSignatureTestCases android.signature.cts.api.system.SignatureTest#testRuntimeCompatibilityWithCurrentApi
Reverted Changes:
Icf9ab3fc0:Input latency & reliability tracking - hide flow
I1096564d5:Input latency & reliability tracking - hide flow
I14e009250:Input latency & reliability tracking - hide flow
Ic32e36b2d:Input latency & reliability tracking
I56f96dc6b:Input latency & reliability tracking
I73dec2e9e:Input latency & reliability tracking

Change-Id: Ia376a1624fb6abf937eb2a335aa75cb3ca9831d8
2022-11-10 13:11:27 +00:00
Pascal Mütschard
d638a60aae Revert "Input latency & reliability tracking - hide flow"
Revert submission 20313761-IME tracking - hide

Bug: b/258637227
Reason for revert: Breaks CtsSystemApiSignatureTestCases android.signature.cts.api.system.SignatureTest#testRuntimeCompatibilityWithCurrentApi
Reverted Changes:
Icf9ab3fc0:Input latency & reliability tracking - hide flow
I1096564d5:Input latency & reliability tracking - hide flow
I14e009250:Input latency & reliability tracking - hide flow
Ic32e36b2d:Input latency & reliability tracking
I56f96dc6b:Input latency & reliability tracking
I73dec2e9e:Input latency & reliability tracking

Change-Id: I0d0ce41e3a4f0d19ff482c2f5ab4884b5f758134
2022-11-10 13:11:27 +00:00
Cosmin Băieș
36d3884041 Merge changes from topics "IME tracking - hide", "IME tracking"
* changes:
  Input latency & reliability tracking - hide flow
  Input latency & reliability tracking
2022-11-10 10:19:00 +00:00
Lan Wei
54716fa8e3 Merge "Improve javadoc for InputConnection#replaceText" 2022-11-10 04:35:24 +00:00
Gaurav Bhola
367b09cc4a Add the systemOverlays() method
- Also rename GENERIC_OVERLAYS to SYSTEM_OVERLAYS

Bug: 232017511
Fix: 244238266
Test: atest WindowInsetsTests
Change-Id: Ib8455f6ae576c7b3f40789de30649d8fc137e3dd
2022-11-09 18:24:13 +00:00
Shu Chen
caa35d5585 Merge "Adds the new API - InputMethodSubtypeBuilder#setSubtypeNameOverride." 2022-11-09 03:01:12 +00:00
Zeyin Wu
a1c0adb050 Add Accessibility API for rate-limiting CONTENT_CHANGE_TYPE* events
Bug: 222759137
Test: ran cts test
Change-Id: Ia49209d7138bd5bd1026dc18210552b3f359664e
2022-11-09 00:15:57 +00:00
Nikolas Havrikov
f583eb6607 Reduce DPAD navigation logspam with killable IME
On Android TV, when the killable IME feature is enabled, navigating
through the interface using the DPAD buttons on a remote controller
leads to logspam on logcat. This CL takes the feature into account
and lowers the severity of the log message about the input event
not being delivered to the IME when appropriate.

Bug: 258201658
Test: manually on a tv device
Change-Id: I04b85aaf13e1442f070d8dfcff7cf9bd599dac0a
2022-11-08 16:01:06 +00:00
Cosmin Băieș
553cb171de Input latency & reliability tracking - hide flow
Test: filter logcat for ImeTracker tag, open some apps with IME connection (e.g. Dialer, Messaging, etc.) and close the soft keyboard, check that tracking reflects observed behaviour
Change-Id: Icf9ab3fc0f7a7116456c13328d22f8b8428a0c79
2022-11-07 17:49:47 +01:00
Cosmin Băieș
6756327922 Input latency & reliability tracking
Test: filter logcat for ImeTracker tag, open some apps with IME connection (e.g. Dialer, Messaging, etc.), check that tracking reflects observed behaviour
Change-Id: I73dec2e9e2d5f919c7a006828ee0b12a998fc7d9
2022-11-07 17:49:41 +01:00
Zeyin Wu
44c8a5b43b Merge "Add setContainerTitle API" 2022-11-07 16:42:17 +00:00
Tiger Huang
fedf2cf795 Merge "Describe requested visibilities in public types (5/n: consumer)" 2022-11-07 07:15:02 +00:00
Zeyin Wu
bf86a1b0ba Add setContainerTitle API
Test: atest android.view.accessibility.cts.AccessibilityNodeInfoTest
Bug: 191984454
Change-Id: I82874c095aab641257a9735654294a06abac3e45
2022-11-06 22:40:27 +00:00
TreeHugger Robot
657812fb22 Merge "Fix some typos in MotionEvent#obtain JavaDoc" 2022-11-04 20:22:38 +00:00
Taran Singh
48cba7c99a Merge "API for realtime Scribe gesture preview" 2022-11-04 18:12:07 +00:00
Harry Cutts
ab98306d9e Merge "Update JavaDoc for InputDevice touchpad sources" 2022-11-04 15:25:17 +00:00
Harry Cutts
3472c79777 Merge "Add MotionEvent#obtain overload for classification" 2022-11-04 13:17:10 +00:00
Rhed Jao
bedef9c26f Merge "Enforce package visibility rules on switch input method apis" 2022-11-04 10:47:38 +00:00
Rhed Jao
567dafb881 Enforce package visibility rules on switch input method apis
Bug: 227207653
Test: atest InputMethodSubtypeTest
Test: atest InputMethodServiceLifecycleTest
Change-Id: Ib5ba67f708b8ebe12b5120c126022eb84ce720cb
2022-11-04 14:16:34 +08:00
Taran Singh
95baa907de API for realtime Scribe gesture preview
Introduce new API to support gesture preview as user is operating over
text.

Bug: 254726230
Bug: 254727073
Test: InputConnectionEndToEndTest

Change-Id: I6c2ac5a5aaeaeab78411d24870f573670304e898
2022-11-03 18:04:00 +00:00
TreeHugger Robot
78f3bff690 Merge "Remove requestCursorUpdatesFromImm() again" 2022-11-03 17:32:13 +00:00
Harry Cutts
ccaf86da8f Fix some typos in MotionEvent#obtain JavaDoc
This was pointed out by a presubmit on the previous CL for an individual
JavaDoc entry, but let's fix it for all of them.

Bug: 257028305
Test: none
Change-Id: I4d0aaf3c4d0cb53a532d523a9802c1363e637b50
2022-11-03 15:57:05 +00:00
Harry Cutts
2892de61dc Add MotionEvent#obtain overload for classification
Bug: 257028305
Test: atest CtsHardwareTestCases (no new failures)
Change-Id: I3255b01fb136b11f4afecc6db4b26725ca3a36d5
2022-11-03 15:41:18 +00:00
John Reck
ae963f8b4f Merge "Add missing nullability annotations" 2022-11-03 14:29:30 +00:00
Tiger
a4b747496b Describe requested visibilities in public types (5/n: consumer)
This CL removes mRequestedVisible from InsetsSourceConsumer since the
information can be queried from InsetsController.

This CL also stores the public insets type in InsetsSourceConsumer.
Eventually, the internal insets type will be removed.

Bug: 253420890
Bug: 234093736
Test: atest ImeInsetsSourceConsumerTest InsetsAnimationControlImplTest
      InsetsControllerTest InsetsSourceConsumerTest
Change-Id: I8e2070676d2161cc9e8fc28a3dd49cefb362f26c
2022-11-03 16:42:54 +08:00
Lan Wei
947fd9335e Improve javadoc for InputConnection#replaceText
Bug: 254278543
Test: atest FrameworksCoreTests:BaseInputConnectionTest
Test: atest CtsInputMethodTestCases:BaseInputConnectionTest

Change-Id: I3e63532eae8349aaff21cfa72ed65f01779103df
2022-11-03 10:24:29 +08:00
TreeHugger Robot
ebb99da896 Merge "Remove an unused param from IMMS#showInputMethodPickerFromClient()" 2022-11-03 00:16:41 +00:00
John Reck
3e79a16b56 Add missing nullability annotations
It's never valid to draw to a null Canvas

Test: make
Change-Id: Iaad788cb9e5f1ff2965d2fac23f7ba7a00069b81
2022-11-02 15:18:46 -04:00
Yohei Yukawa
a488ba266c Remove an unused param from IMMS#showInputMethodPickerFromClient()
This is the 2nd attempt to submit this cleanup [1], after a revert [2] due to some build failure.

This is a follow up CL to our previous CL [3], which introduced

  InputMethodManagerService#showInputMethodPickerFromClient(
          @NonNull IInputMethodClient client,
          int auxiliarySubtypeMode, int displayId);

Somehow the "client" has never been used, which is fine because the
actual caller verification is done by requiring WRITE_SECURE_SETTINGS
permission.

Let's remove such an unused parameter for simplicity.

There must be no observable behavior change.

 [1]: I2f27160cbe7d83201c8f52dbb6dcb774a5b8ae43
      3efbbb5e49
 [2]: I343828ad83d50436211004753f1b9ba1b13b60ca
      2fb98cdab1
 [3]: Ic7d7c5a7ad8005a3fbd9d1c1b73e3c5a39a07001
      0b05f9e49d

Bug: 234882948
Bug: 256952514
Test: presubmit
Test: lunch aosp_bramble-userdebug && make -j
Change-Id: Ia536d8793f0022179dfafd1cbf21091537375992
2022-11-02 18:31:56 +00:00
TreeHugger Robot
5a97c93a7a Merge "Add @hide IMM#setRequestCursorUpdateDisplayIdCheck()" 2022-11-02 17:29:41 +00:00
Yohei Yukawa
d4b0e8a107 Add @hide IMM#setRequestCursorUpdateDisplayIdCheck()
This is a follow up CL to our previous CL [1], which re-introduced

  InputMethodManager#reportVirtualDisplayGeometry()

for some special form factors.

For apps that only aim to bypass display ID mismatch check in

  RemoteInputConnectionImpl#requestCursorUpdatesInternal(),

this CL gives a much simpler and easier-to-maintain @hide method

  InputMethodManager#setRequestCursorUpdateDisplayIdCheck().

  [1]: I35b491da5a340844e17542d7a6198f8152bbeda3
       708c957fa3

Bug: 224424149
Bug: 256926300
Test: presubmit
Change-Id: I9e1f62e3d5d2a385dce8a9633b5b73f8e7f0ccef
2022-11-02 10:26:49 -07:00
Ziqi Chen
6745a77c6c Merge "Add a new API CursorAnchorInfo#getTextAppearanceInfo()." 2022-11-02 08:18:02 +00:00
Hieu Dang
4826cefb6c Merge "Revert "Remove an unused param from IMMS#showInputMethodPickerFromClient()"" 2022-11-02 07:20:24 +00:00
Hieu Dang
2fb98cdab1 Revert "Remove an unused param from IMMS#showInputMethodPickerFromClient()"
This reverts commit 3efbbb5e49.

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?branch=git_master&target=aosp_bramble-userdebug&lkgb=9245415&lkbb=9246274&fkbb=9245423, bug https://buganizer.corp.google.com/issues/256952514

Change-Id: I343828ad83d50436211004753f1b9ba1b13b60ca
Bug: 256952514
2022-11-02 07:19:39 +00:00
czq
50f792e09d Add a new API CursorAnchorInfo#getTextAppearanceInfo().
Add a new group of information related to text appearance in
CursorAnchorInfo, which is extracted from TextView.

Bug: 231894524

Test: atest android.view.inputmethod.cts.CursorAnchorInfoTest#testBuilder
atest android.view.inputmethod.cts.CursorAnchorInfoTest#testEquality
atest android.view.inputmethod.cts.InputMethodServiceTest#testOnUpdateCursorAnchorInfo

Change-Id: I8b96f055506b0a426dcfc6334db867dda7073868
2022-11-02 11:40:08 +08:00
Yohei Yukawa
e7058e49a7 Merge "Remove an unused param from IMMS#showInputMethodPickerFromClient()" 2022-11-02 01:52:35 +00:00
Yohei Yukawa
e21c66fb60 Merge "Add missing @RequiresPermission to IMM" 2022-11-02 00:08:39 +00:00
Yohei Yukawa
515e3ce276 Merge "Clarify required permission in IMM#getInputMethodListAsUser()" 2022-11-02 00:05:48 +00:00
TreeHugger Robot
f65ce2308b Merge "Add threading comments for the delegate initiation callback" 2022-11-01 23:52:56 +00:00
Yohei Yukawa
3a05ca923d Remove requestCursorUpdatesFromImm() again
This CL removes an unused method

  RemoteInputConnectionImpl#requestCursorUpdatesFromImm(),

which was originally introduced [1] then removed [2], and
accidentally added again [3].

Anyway, this method is no longer used and can be removed safely.

 [1]: I3d6b1728d62139785593af14c24cb52bf2c91e31
      71aa1a31d1
 [2]: Ia72a9fe0ceac1798ee1989eaae3906e8e1b696bf
      5854c92bad
 [3]: I53bcb62e03ac1c371feb60d1385c88c921754092
      3e3ff1a3d2

Bug: 210039666
Test: presubmit
Change-Id: I4d0bf0ac371e1f9f214258906231d6ae85bdce3e
2022-11-01 16:14:04 -07:00
Taran Singh
79dbdbac77 Merge "Make text optional for InsertGesture" 2022-11-01 22:44:55 +00:00
TYM Tsai
98e013f664 Merge "Reset Autofill dialog if the content is changed" 2022-11-01 22:17:38 +00:00
TYM Tsai
6106c85a44 Merge "Avoid to hold a strong reference to Context object" 2022-11-01 22:16:44 +00:00
Justin Ghan
c4409a13be Add threading comments for the delegate initiation callback
Bug: 228100684
Bug: 256870186
Test: N/A
Change-Id: I6db21adad640d27a3efd020aa9f829276993bbe7
2022-11-01 14:18:24 -07:00