Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add @hide IMM#setRequestCursorUpdateDisplayIdCheck()

Browse Source 
This is a follow up CL to our previous CL [1], which re-introduced

  InputMethodManager#reportVirtualDisplayGeometry()

for some special form factors.

For apps that only aim to bypass display ID mismatch check in

  RemoteInputConnectionImpl#requestCursorUpdatesInternal(),

this CL gives a much simpler and easier-to-maintain @hide method

  InputMethodManager#setRequestCursorUpdateDisplayIdCheck().

  [1]: I35b491da5a340844e17542d7a6198f8152bbeda3
       708c957fa3

Bug: 224424149
Bug: 256926300
Test: presubmit
Change-Id: I9e1f62e3d5d2a385dce8a9633b5b73f8e7f0ccef
This commit is contained in:
Yohei Yukawa
2022-11-02 10:26:49 -07:00
parent 706c84fd20
commit d4b0e8a107
2 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
core/java/android/view/inputmethod/InputMethodManager.java
View File

@@ -128,6 +128,7 @@ import java.util.Map;
import java.util.Objects;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.function.Consumer;
/**
@@ -3621,6 +3622,32 @@ public final class InputMethodManager {
return IInputMethodManagerGlobalInvoker.getInputMethodWindowVisibleHeight(mClient);
}
/**
* {@code true} means that
* {@link RemoteInputConnectionImpl#requestCursorUpdatesInternal(int, int, int)} returns
* {@code false} when the IME client and the IME run in different displays.
*/
final AtomicBoolean mRequestCursorUpdateDisplayIdCheck = new AtomicBoolean(true);
/**
* Controls the display ID mismatch validation in
* {@link RemoteInputConnectionImpl#requestCursorUpdatesInternal(int, int, int)}.
*
* <p>{@link #updateCursorAnchorInfo(View, CursorAnchorInfo)} is not guaranteed to work
* correctly when the IME client and the IME run in different displays. This is why
* {@link RemoteInputConnectionImpl#requestCursorUpdatesInternal(int, int, int)} returns
* {@code false} by default when the display ID does not match. This method allows special apps
* to override this behavior when they are sure that it should work.</p>
*
* <p>By default the validation is enabled.</p>
*
* @param enabled {@code false} to disable the display ID validation.
* @hide
*/
public void setRequestCursorUpdateDisplayIdCheck(boolean enabled) {
mRequestCursorUpdateDisplayIdCheck.set(enabled);
}
/**
* An internal API for {@link android.hardware.display.VirtualDisplay} to report where its
* embedded virtual display is placed.

3
core/java/android/view/inputmethod/RemoteInputConnectionImpl.java
View File

@@ -1071,7 +1071,8 @@ final class RemoteInputConnectionImpl extends IRemoteInputConnection.Stub {
Log.w(TAG, "requestCursorAnchorInfo on inactive InputConnection");
return false;
}
if (mParentInputMethodManager.getDisplayId() != imeDisplayId
if (mParentInputMethodManager.mRequestCursorUpdateDisplayIdCheck.get()
&& mParentInputMethodManager.getDisplayId() != imeDisplayId
&& !mParentInputMethodManager.hasVirtualDisplayToScreenMatrix()) {
// requestCursorUpdates() is not currently supported across displays.
return false;