Commit Graph

13493 Commits

Author SHA1 Message Date
Evan Rosky
5b2a94dab2 Merge "Give SystemUI a chance to participate in display rotation" 2019-11-12 20:54:34 +00:00
TreeHugger Robot
786904b62f Merge "[Shadows] Add an api to draw shadows around a surface. (1/n)" 2019-11-12 20:42:12 +00:00
Evan Rosky
69cace4057 Give SystemUI a chance to participate in display rotation
This adds support for registering a single DisplayRotationController
to WMS. It gives a chance for the controller to suggest some
task changes to be executed along with a display rotation. There
is only one because it's a 2-way communication and there is only
intended to be one client for now.

This allows us to move Split and PiP presentation/layout logic out
of WM into systemui because WM no-longer needs to be the one
calculating the new bounds of everything during rotation.

This uses the windowcontainer transaction because all the
configuration changes and the display rotation need to happen
synchronously; otherwise, relayouts can occur after the display
is rotated, but before the configuration changes are applied.
When this happens, apps get incorrect bounds/insets which can
trigger erroneous lifecycle events in the app.

The flow is like this:
1. DisplayContent/Rotation freezes screen
2. DisplayRotationController is notified of a rotation and provided a
   callback.
3. The Controller then evaluates/queues some task changes in
   a transaction and, when done, fires the provided callback.
4. The callback applies the config change transaction and continues
   the rest of the rotation synchronously.

The DisplayWindowController is sys-ui piece that serves as an
interface between system-ui components and display-related wm
logic. For now it just facilitates the rotation calculation, but
in the future it will have more general utility for display logic
like inset/bounds calculation.

Bug: 124011688
Bug: 133381284
Test: Added some wmtests and coretests.
Change-Id: If10695f44fa076725ba17746842f6fbd64da5d20
2019-11-11 18:10:08 -08:00
Jorim Jaggi
5fdaa0c9af Merge "Remove FEATURE_SWIPE_TO_DISMISS functionality" 2019-11-11 13:10:30 +00:00
Jorim Jaggi
263f6dd52b Merge "Remove PRIVATE_FLAG_INHERIT_TRANSLUCENT_DECOR" 2019-11-11 12:10:28 +00:00
Jorim Jaggi
a2e648e370 Remove PRIVATE_FLAG_INHERIT_TRANSLUCENT_DECOR
Unused

Test: Boots
Change-Id: I35b6fa41de1da8ac3b3435ec4a8506e88bdd6db7
Bug: 144257103
2019-11-11 10:53:16 +00:00
Taran Singh
4e3f6af6f1 Merge "Window with FLAG_NOT_FOCUSABLE cant be IME target." 2019-11-11 04:11:43 +00:00
Joshua Baxter
386d18cccb Merge "docs: remove incorrect (default) identifiers" into qt-dev am: 2c7d94c7ed am: b2a8b29d10 am: 311218304a
am: 6d92ef5ea5

Change-Id: If87405cf3776f3823b722a0cc54728c2ee7932a5
2019-11-08 15:42:37 -08:00
Joshua Baxter
6d92ef5ea5 Merge "docs: remove incorrect (default) identifiers" into qt-dev am: 2c7d94c7ed am: b2a8b29d10
am: 311218304a

Change-Id: I9a27040720cbf66e070403c3ae70f3fe5ce0c001
2019-11-08 15:34:36 -08:00
Joshua Baxter
311218304a Merge "docs: remove incorrect (default) identifiers" into qt-dev am: 2c7d94c7ed
am: b2a8b29d10

Change-Id: Ie1d730b2777f85cd2a2d601576aeedd5e3728620
2019-11-08 15:26:57 -08:00
Joshua Baxter
b2a8b29d10 Merge "docs: remove incorrect (default) identifiers" into qt-dev
am: 2c7d94c7ed

Change-Id: I3b86d60b47443b7b3d50deccc81048b78c0e1dc7
2019-11-08 15:18:53 -08:00
Tarandeep Singh
0ffa15ab5f Window with FLAG_NOT_FOCUSABLE cant be IME target.
Any window that sets FLAG_NOT_FOCUSABLE should not be considered IME target.
IME subsystem starts input on a window when it receives focus, if window never
intended to receive focus, it should not considered an IME target either.
Also, fix the broken javadoc for ALT_FOCUSABLE_IM.

Fix: 143898978
Bug: 140641950
Test: atest WindowStateTests
      atest FocusHandlingTest
      atest WindowManager_LayoutParamsTest
      Also manually using steps:
      1. Launch gmail compose activity
      2. start typing in receipient field
      3. verify that suggestions popup window w/ FLAG_NOT_FOCUSABLE doesn't
         become IME target.

Change-Id: Ifa8e7345c2c9ad3730df86100003918b12fb533e
2019-11-08 11:23:35 -08:00
Artur Satayev
3be4d59369 Merge "Add @UnsupportedAppUsage annotations for max-p." am: 8893f158c6
am: da4d6567c2

Change-Id: Iff80c388dec2c6f8184b739be6fb38b8ec8a1a49
2019-11-08 09:49:03 -08:00
Artur Satayev
da4d6567c2 Merge "Add @UnsupportedAppUsage annotations for max-p."
am: 8893f158c6

Change-Id: I2f249063c274b54a58a24cda23f1d5a60fa14540
2019-11-08 09:38:12 -08:00
Artur Satayev
ee9c6e7571 Add @UnsupportedAppUsage annotations for max-p.
See go/UnsupportedAppUsage for more details.

These have already been greylisted, however due to bugs/omissions in the tooling have been kept in go/greylist-txt instead of being annotated in the code.

Bug: 137350495
Test: m
Change-Id: I5aa29a49b193db47aaee4d3a756c17f48cc9f0b1
Merged-In: I5aa29a49b193db47aaee4d3a756c17f48cc9f0b1
2019-11-08 16:17:13 +00:00
Derek Sollenberger
36cf8b2c12 Merge "Remove native calls to HWUI from Surface and use the public API instead" 2019-11-08 13:40:22 +00:00
TreeHugger Robot
79733bbf03 Merge "Update input policy to handle embedded windows" 2019-11-08 10:39:55 +00:00
Joanne Chung
b26a6c567a Merge "Allow to use ExtService as TextClassifierService" 2019-11-08 05:15:30 +00:00
Yunfan Chen
a232661f36 Merge "Hook up TaskDescription into set bar color calls (6/N)" 2019-11-08 02:22:05 +00:00
Vishnu Nair
5cf2531977 Update input policy to handle embedded windows
ANR - If embedded windows are slow in handling inputs the system should blame the embedded app.

PointerDownOutsideFocus - if a user taps outside the currently focused window onto an
embedded window, treat it as if the host window was tapped.

Rename blessInputSurface -> grantInputChannel and add a name to embedded windows.

Bug: 134365580
Test: b WindowlessWmTest
Test: atest CtsWindowManagerDeviceTestCases:WindowlessWmTests

Change-Id: If88970cf6ce17669b41fec995535151a492fab12
2019-11-07 15:54:27 -08:00
Hongming Jin
b640dac6e4 Merge "Convert AccessibilityAction into a parcelable." 2019-11-07 18:11:34 +00:00
Yunfan Chen
91b3a1bd14 Hook up TaskDescription into set bar color calls (6/N)
This patch will update the task description when the app calls
setStatusBarColor or setNavigationBarColor. The status bar is updated
but the information is not reflected in the task description without
this patch.

Bug: 132756841
Bug: 113253712
Test: Test with the test app in b/132756841. The task description is
      updated as expected.
Test: go/wm-smoke
Change-Id: I4ba1e5e7dd0f096cba40221450a8861e3d578e3c
2019-11-06 16:57:05 -08:00
TreeHugger Robot
d660afae57 Merge "Be less slow" 2019-11-07 00:41:21 +00:00
Vishnu Nair
d87984dff5 [Shadows] Add an api to draw shadows around a surface. (1/n)
Bug: 136561771
Test: go/wm-smoke

Change-Id: Ibbf87d93ec30109dae0fbb112e4e20bae5a096f2
2019-11-06 14:43:22 -08:00
Joshua Baxter
5411869170 docs: remove incorrect (default) identifiers
Change-Id: I4ce6bc8a7b0e2f18055416a21f465cd2cfe4ec66
test: make ds-docs
bug: 112679894
2019-11-06 22:14:11 +00:00
Joshua Baxter
7d7562e9ac Merge "docs: fix typos" into qt-dev am: d732cbb7bd am: 77514bd077 am: 208e73ca76
am: fc66e118db

Change-Id: I2f3df59cdd979fc3543dc18ef9beb3ea06061030
2019-11-06 14:11:41 -08:00
Joshua Baxter
fc66e118db Merge "docs: fix typos" into qt-dev am: d732cbb7bd am: 77514bd077
am: 208e73ca76

Change-Id: I492eb05a7292f17df50190ae5325e5c99bb0407e
2019-11-06 13:57:03 -08:00
Joshua Baxter
11cffb4eb2 Merge "docs: fix typos" into qt-dev am: 7bd7afabb8 am: 53fba24239 am: 20148858f5
am: e9a62d5f86

Change-Id: I5a3342cbe5e225806315ab6454fc6b874f21f3a2
2019-11-06 13:50:30 -08:00
Joshua Baxter
208e73ca76 Merge "docs: fix typos" into qt-dev am: d732cbb7bd
am: 77514bd077

Change-Id: I57d192cc779667458923fed99f71c7bf0ae1b8ff
2019-11-06 13:41:26 -08:00
Joshua Baxter
e9a62d5f86 Merge "docs: fix typos" into qt-dev am: 7bd7afabb8 am: 53fba24239
am: 20148858f5

Change-Id: Ibf2e7a9c1b8e31669226e4b27c5a09ae2ed1a219
2019-11-06 13:41:00 -08:00
Joshua Baxter
20148858f5 Merge "docs: fix typos" into qt-dev am: 7bd7afabb8
am: 53fba24239

Change-Id: I2d60f8aa3371e1fc77146e3571a3a89c5acaa253
2019-11-06 13:28:46 -08:00
Joshua Baxter
77514bd077 Merge "docs: fix typos" into qt-dev
am: d732cbb7bd

Change-Id: Ie5d13bceacd0392bebb797456c7ed3d0d2d906da
2019-11-06 13:26:00 -08:00
Joshua Baxter
53fba24239 Merge "docs: fix typos" into qt-dev
am: 7bd7afabb8

Change-Id: I2d9f0e92ac269000c9d0031d81e787688e44bdea
2019-11-06 13:21:12 -08:00
Joshua Baxter
d732cbb7bd Merge "docs: fix typos" into qt-dev 2019-11-06 21:01:14 +00:00
Joshua Baxter
914bda7659 docs: fix typos
test: make ds-docs
bug: 36974889
2019-11-06 21:01:00 +00:00
Joshua Baxter
ec27701c78 docs: fix typos
Change-Id: Ie238360300cac54bd4717b4ff75d5534f82e0307
test: make ds-docs
bug: 36948876
2019-11-06 20:53:55 +00:00
Derek Sollenberger
4aa30d07c5 Remove native calls to HWUI from Surface and use the public API instead
Test: CtsGraphicsTestCases and CtsWindowManagerDeviceTestCases
Bug: 137655431
Change-Id: I8427f96e4f33905e8cabb6d48a0cc29443b9ed63
2019-11-06 14:31:44 -05:00
TreeHugger Robot
0c2972635a Merge "Enables multiple clickable links on the SaveUi" 2019-11-06 13:48:11 +00:00
TYM Tsai
8af721d0af Enables multiple clickable links on the SaveUi
Enables multiple links for URLSpan on description TextViews. Also fixes
issue about cannot restore the save UI while back from the activity which
URLSpan launched.

Bug: 133515042
Test: manual
Test: atest CtsAutoFillServiceTestCases
Change-Id: I8a97c2eaccdde78622b5b5432c9b00ce19d871df
2019-11-06 13:56:56 +08:00
Joanne Chung
b50ab4bab8 Allow to use ExtService as TextClassifierService
1. Define a trust TextClassifierService list which contains ExtService. And
also define a DeviceConfig flag which can be set to the TextClassifierService
we would like to use. Because the TextClassfierService can be set to a side-load
app, e.g. CTS tests. If the override flag is not one of the packages in the
trust TextClassifierService list, it should be able to see only text from
its own UID.
2. Made TextClassifierService available for testing.
3. Fix the incoreect order for onConnected().
4. Fix API Lint errors.

Bug: 141111813
Bug: 143249163
Test: atest FrameworksCoreTests:android.view.textclassifier
Test: Manual. dumpsys to check current TextClassifierService. Change flag
to another service, and then check TextClassifierService changing to
expected TextClassifierService.
Test: Manual. Use local TextClassifierService to make sure the service
call order of connection callback and API call is correct.
Change-Id: I37ff298f0c65ae0469bd54e30f1ebf48b77c126c
2019-11-06 13:38:56 +08:00
TreeHugger Robot
d4deaec1a5 Merge "Add missing nullability annotations" 2019-11-05 23:58:53 +00:00
Chavi Weingarten
ffb4315a85 Merge "Added format to WindowlessWindowManager SurfaceControls" 2019-11-05 23:02:17 +00:00
Yinglei Wang
0cf1081834 Merge "Make getStateDescription() in View none final" 2019-11-05 21:20:01 +00:00
Jorim Jaggi
e06b1fd0f5 Remove FEATURE_SWIPE_TO_DISMISS functionality
Not used anymore by any product.

Bug: 143346248
Test: Boots
Change-Id: I21286e62f73ec34f7d5ca040cd614838c9cd4276
2019-11-05 19:14:54 +01:00
Taran Singh
90ebd2b809 Merge "Move startInput for WINDOW_FOCUS_GAIN to background thread" 2019-11-05 17:16:04 +00:00
TreeHugger Robot
60c4367006 Merge "Remove InputChannel::setToken" 2019-11-05 01:41:56 +00:00
Hongming Jin
347d803da8 Convert AccessibilityAction into a parcelable.
Bug: 136286274
Test: atest AccessiblitityActionTest
Change-Id: I74e2c76eede0a370cefe5250f6d7fd61017e4c3b
2019-11-04 17:27:51 -08:00
John Reck
582f6bdcb0 Add missing nullability annotations
Bug: 123674035
Test: none
Change-Id: I5fa3a52f98a495b25c8aa01554ebba73ac89eb9f
2019-11-04 21:50:44 +00:00
chaviw
183aa5bc71 Added format to WindowlessWindowManager SurfaceControls
Currently, format is used to check for opaque but is not sent to
SurfaceFlinger to use when creating the SurfaceControl.

Test: format is set for WindowlessWindowManager
Bug: 134365580
Change-Id: Ia0707e49fa635313d3d54ca825173c71d2b17f14
2019-11-04 10:56:34 -08:00
TreeHugger Robot
f822d418e3 Merge "Add additional javadoc for listener parameter." 2019-11-04 16:27:33 +00:00