Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Call isEmpty() instead of constructing a new object to compare

Browse Source 
A recent change in Skia
(https://skia-review.googlesource.com/c/skia/+/573636) moves operator==
into the cpp file, where this file cannot access it due to libhwui's map
file. Call isEmpty, which is still in the header file, and skips
unnecessary creation of a new object anyway.

Bug: NA
Test: AImageDecoderTest
Change-Id: I1dec89a38e248138ace364e8cb7259eb777e8871
This commit is contained in:
Leon Scroggins III
2022-08-26 10:07:06 -04:00
parent c6fbc786f8
commit ff37ce9727
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
native/graphics/jni/imagedecoder.cpp
View File

@@ -381,7 +381,7 @@ int AImageDecoder_setCrop(AImageDecoder* decoder, ARect crop) {
SkIRect cropIRect;
cropIRect.setLTRB(crop.left, crop.top, crop.right, crop.bottom);
SkIRect* cropPtr = cropIRect == SkIRect::MakeEmpty() ? nullptr : &cropIRect;
SkIRect* cropPtr = cropIRect.isEmpty() ? nullptr : &cropIRect;
return imageDecoder->setCropRect(cropPtr)
? ANDROID_IMAGE_DECODER_SUCCESS : ANDROID_IMAGE_DECODER_BAD_PARAMETER;
}