Bump refcount of canvas created for Picture
Both the Canvas and Picture objects will unref the canvas in their finalizers, so an extra ref is needed. This had been present but was inadvertently removed in the patch "Refactor android.graphics.Picture JNI bindings." This patch simply restores the previous ref and comment. Bug: 16399257 Change-Id: I9911826bd0e668bd25546ef54b0c9c1d467538c8
This commit is contained in:
@@ -42,6 +42,10 @@ Canvas* Picture::beginRecording(int width, int height) {
|
||||
mWidth = width;
|
||||
mHeight = height;
|
||||
SkCanvas* canvas = mRecorder->beginRecording(width, height, NULL, 0);
|
||||
// the java side will wrap this guy in a Canvas.java, which will call
|
||||
// unref in its finalizer, so we have to ref it here, so that both that
|
||||
// Canvas.java and our picture can both be owners
|
||||
canvas->ref();
|
||||
return Canvas::create_canvas(canvas);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user