Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix NPE in *GenerateChallengeClient

Browse Source 
Bug: 191989346
Bug: 191684201
Test: N/A
Change-Id: I72e59aa8756f44b332ed5b18e248871baae105ed
This commit is contained in:
Ilya Matyukhin
2021-06-28 12:30:07 -07:00
parent 27b63bb150
commit febab8c34d
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceGenerateChallengeClient.java
View File

@@ -52,7 +52,13 @@ public class FaceGenerateChallengeClient extends GenerateChallengeClient<ISessio
void onChallengeGenerated(int sensorId, int userId, long challenge) {
try {
getListener().onChallengeGenerated(sensorId, userId, challenge);
final ClientMonitorCallbackConverter listener = getListener();
if (listener == null) {
Slog.e(TAG, "Listener is null in onChallengeGenerated");
mCallback.onClientFinished(this, false /* success */);
return;
}
listener.onChallengeGenerated(sensorId, userId, challenge);
mCallback.onClientFinished(this, true /* success */);
} catch (RemoteException e) {
Slog.e(TAG, "Unable to send challenge", e);

8
services/core/java/com/android/server/biometrics/sensors/fingerprint/aidl/FingerprintGenerateChallengeClient.java
View File

@@ -53,7 +53,13 @@ class FingerprintGenerateChallengeClient extends GenerateChallengeClient<ISessio
void onChallengeGenerated(int sensorId, int userId, long challenge) {
try {
getListener().onChallengeGenerated(sensorId, userId, challenge);
final ClientMonitorCallbackConverter listener = getListener();
if (listener == null) {
Slog.e(TAG, "Listener is null in onChallengeGenerated");
mCallback.onClientFinished(this, false /* success */);
return;
}
listener.onChallengeGenerated(sensorId, userId, challenge);
mCallback.onClientFinished(this, true /* success */);
} catch (RemoteException e) {
Slog.e(TAG, "Unable to send challenge", e);