Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CEC : Add validator for give deck status message

Browse Source 
Test: atest HdmiCecMessageValidatorTest
Bug: 170811408
Change-Id: Ifce7a960af0e9ca8f3a7ee02d6a523e2368f1da0
This commit is contained in:
Shraddha Basantwani
2020-11-02 11:51:44 +05:30
parent b6db9b9f15
commit fd4e760c79
2 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/core/java/com/android/server/hdmi/HdmiCecMessageValidator.java
View File

@@ -153,6 +153,10 @@ public class HdmiCecMessageValidator {
Constants.MESSAGE_DECK_CONTROL, new OneByteRangeValidator(0x01, 0x04), DEST_DIRECT);
addValidationInfo(
Constants.MESSAGE_DECK_STATUS, new OneByteRangeValidator(0x11, 0x1F), DEST_DIRECT);
addValidationInfo(
Constants.MESSAGE_GIVE_DECK_STATUS,
new OneByteRangeValidator(0x01, 0x03),
DEST_DIRECT);
// TODO: Handle messages for the Tuner Control.

12
services/tests/servicestests/src/com/android/server/hdmi/HdmiCecMessageValidatorTest.java
View File

@@ -376,6 +376,18 @@ public class HdmiCecMessageValidatorTest {
assertMessageValidity("40:1B:20").isEqualTo(ERROR_PARAMETER);
}
@Test
public void isValid_giveDeckStatus() {
assertMessageValidity("40:1A:01:F8").isEqualTo(OK);
assertMessageValidity("40:1A:03").isEqualTo(OK);
assertMessageValidity("4F:1A:01").isEqualTo(ERROR_DESTINATION);
assertMessageValidity("F0:1A:03").isEqualTo(ERROR_SOURCE);
assertMessageValidity("40:1A").isEqualTo(ERROR_PARAMETER_SHORT);
assertMessageValidity("40:1A:00").isEqualTo(ERROR_PARAMETER);
assertMessageValidity("40:1A:04").isEqualTo(ERROR_PARAMETER);
}
private IntegerSubject assertMessageValidity(String message) {
return assertThat(mHdmiCecMessageValidator.isValid(buildMessage(message)));
}