Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a broken test by mocking PackageManager

Browse Source 
There is no email app in AOSP, and thus the test fails.
Mocking the package manager output to fix the test

Test: atest frameworks/base/core/tests/coretests/src/android/view/textclassifier/TextClassifierTest.java

Fixes: 139536812
Fixes: 145209230
Fixes: 145287677

Change-Id: I86026724c81f9d928eb652f25fc968911f93001b
Merged-In: Ie2dd599528074266d45044b1785a1b7d71caa1d3

Exempt-From-Owner-Approval: Re-enabling test in TEST_MAPPING
for AOSP.
This commit is contained in:
Tony Mak
2019-11-27 17:52:46 +00:00
committed by Ian Kasprzak
parent 10f4d427cd
commit fbe852495c
4 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
core/java/android/view/accessibility/TEST_MAPPING
View File

@@ -30,9 +30,6 @@
},
{
"exclude-annotation": "androidx.test.filters.FlakyTest"
},
{
"exclude-filter": "android.view.textclassifier.TextClassifierTest#testSuggetsConversationActions_deduplicate"
}
]
}

3
core/java/android/view/textclassifier/TEST_MAPPING
View File

@@ -8,9 +8,6 @@
},
{
"exclude-annotation": "androidx.test.filters.FlakyTest"
},
{
"exclude-filter": "android.view.textclassifier.TextClassifierTest#testSuggetsConversationActions_deduplicate"
}
]
}

9
core/tests/coretests/src/android/view/textclassifier/TextClassifierTest.java
View File

@@ -529,8 +529,10 @@ public class TextClassifierTest {
}
@Test
public void testSuggetsConversationActions_deduplicate() {
if (isTextClassifierDisabled()) return;
public void testSuggestConversationActions_deduplicate() {
Context context = new FakeContextBuilder()
.setIntentComponent(Intent.ACTION_SENDTO, FakeContextBuilder.DEFAULT_COMPONENT)
.build();
ConversationActions.Message message =
new ConversationActions.Message.Builder(
ConversationActions.Message.PERSON_USER_OTHERS)
@@ -541,7 +543,8 @@ public class TextClassifierTest {
.setMaxSuggestions(3)
.build();
ConversationActions conversationActions = mClassifier.suggestConversationActions(request);
TextClassifier classifier = new TextClassifierImpl(context, TC_CONSTANTS);
ConversationActions conversationActions = classifier.suggestConversationActions(request);
Truth.assertThat(conversationActions.getConversationActions()).isEmpty();
}

6
services/accessibility/TEST_MAPPING
View File

@@ -52,9 +52,6 @@
},
{
"exclude-annotation": "androidx.test.filters.FlakyTest"
},
{
"exclude-filter": "android.view.textclassifier.TextClassifierTest#testSuggetsConversationActions_deduplicate"
}
]
},
@@ -66,9 +63,6 @@
},
{
"exclude-annotation": "androidx.test.filters.FlakyTest"
},
{
"exclude-filter": "android.view.textclassifier.TextClassifierTest#testSuggetsConversationActions_deduplicate"
}
]
}