Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Page shredder callback invoked on the wrong thread.

Browse Source 
The code executed in the shredder completion callback must
be called on the main thread but instead it was called on
another one. This led to a crash.

bug:17514533

Change-Id: Id9e86d38a90fedadc60f967b193470fd83eb3362
This commit is contained in:
Svetoslav
2014-09-15 18:28:51 -07:00
parent f230c5d21b
commit fb3532eea3
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/PrintSpooler/src/com/android/printspooler/ui/PrintActivity.java
View File

@@ -61,7 +61,6 @@ import android.view.View;
import android.view.View.OnClickListener;
import android.view.View.OnFocusChangeListener;
import android.view.ViewGroup;
import android.view.accessibility.AccessibilityEvent;
import android.view.inputmethod.InputMethodManager;
import android.widget.AdapterView;
import android.widget.AdapterView.OnItemSelectedListener;
@@ -2303,19 +2302,20 @@ public class PrintActivity extends Activity implements RemotePrintDocument.Updat
new AsyncTask<Void, Void, Void>() {
@Override
protected Void doInBackground(Void... params) {
try {
// It's OK to access the data members as they are
// final and this code is the last one to touch
// them as shredding is the very last step, so the
// UI is not interactive at this point.
shredPages(editor);
updatePrintJob();
} finally {
mContext.unbindService(PageShredder.this);
mCallback.run();
}
// It's OK to access the data members as they are
// final and this code is the last one to touch
// them as shredding is the very last step, so the
// UI is not interactive at this point.
shredPages(editor);
updatePrintJob();
return null;
}
@Override
protected void onPostExecute(Void aVoid) {
mContext.unbindService(PageShredder.this);
mCallback.run();
}
}.executeOnExecutor(AsyncTask.SERIAL_EXECUTOR);
}