Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

More debugging for issue #17656716: Unhandled exception in Window Manager

Browse Source 
Change-Id: I81d3678e21d293d5896c467ae5c6739c82cfaa95
This commit is contained in:
Dianne Hackborn
2014-09-26 15:46:24 -07:00
parent 17580af3cb
commit fad079dc5d
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/java/android/os/Binder.java
View File

@@ -387,10 +387,26 @@ public class Binder implements IBinder {
}
}
static void checkParcel(Parcel parcel, String msg) {
static void checkParcel(IBinder obj, int code, Parcel parcel, String msg) {
if (parcel.dataSize() >= 800*1024) {
// Trying to send > 800k, this is way too much
Slog.wtfStack(TAG, msg + parcel.dataSize());
StringBuilder sb = new StringBuilder();
sb.append(msg);
sb.append(": on ");
sb.append(obj);
sb.append(" calling ");
sb.append(code);
sb.append(" size ");
sb.append(parcel.dataSize());
sb.append(" (data: ");
parcel.setDataPosition(0);
sb.append(parcel.readInt());
sb.append(", ");
sb.append(parcel.readInt());
sb.append(", ");
sb.append(parcel.readInt());
sb.append(")");
Slog.wtfStack(TAG, sb.toString());
}
}
@@ -432,7 +448,7 @@ public class Binder implements IBinder {
reply.writeException(re);
res = true;
}
checkParcel(reply, "Unreasonably large binder reply buffer: ");
checkParcel(this, code, reply, "Unreasonably large binder reply buffer");
reply.recycle();
data.recycle();
return res;
@@ -448,7 +464,7 @@ final class BinderProxy implements IBinder {
}
public boolean transact(int code, Parcel data, Parcel reply, int flags) throws RemoteException {
Binder.checkParcel(data, "Unreasonably large binder buffer: ");
Binder.checkParcel(this, code, data, "Unreasonably large binder buffer");
return transactNative(code, data, reply, flags);
}