Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't show home controls complication if not available.

Browse Source 
There is a toggle to disable home controls in Settings, and we need to
honor that toggle when determining if the complication should be shown
on the dream.

Bug: 278964460
Test: atest DreamOverlayStateControllerTest
Test: flashed device and disabled toggle in settings, verified home
controls does not show on clock dream

Change-Id: I4e72f4619fd0ebbf5a78620796f0114ceabc9365
(cherry picked from commit 2955b16317)
This commit is contained in:
Lucas Silva
2023-04-21 14:54:13 -04:00
parent 3bf8b7557d
commit f7cf03045f
2 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/SystemUI/src/com/android/systemui/dreams/DreamOverlayStateController.java
View File

@@ -197,7 +197,8 @@ public class DreamOverlayStateController implements
if (mShouldShowComplications) {
return (requiredTypes & getAvailableComplicationTypes()) == requiredTypes;
}
return (requiredTypes & mSupportedTypes) == requiredTypes;
final int typesToAlwaysShow = mSupportedTypes & getAvailableComplicationTypes();
return (requiredTypes & typesToAlwaysShow) == requiredTypes;
})
.collect(Collectors.toCollection(HashSet::new))
: mComplications);

28
packages/SystemUI/tests/src/com/android/systemui/dreams/DreamOverlayStateControllerTest.java
View File

@@ -353,6 +353,34 @@ public class DreamOverlayStateControllerTest extends SysuiTestCase {
}
}
@Test
public void testHomeControlsDoNotShowIfNotAvailable_featureEnabled() {
when(mFeatureFlags.isEnabled(Flags.ALWAYS_SHOW_HOME_CONTROLS_ON_DREAMS)).thenReturn(true);
final DreamOverlayStateController stateController = getDreamOverlayStateController(true);
stateController.setShouldShowComplications(true);
final Complication homeControlsComplication = Mockito.mock(Complication.class);
when(homeControlsComplication.getRequiredTypeAvailability())
.thenReturn(Complication.COMPLICATION_TYPE_HOME_CONTROLS);
stateController.addComplication(homeControlsComplication);
final DreamOverlayStateController.Callback callback =
Mockito.mock(DreamOverlayStateController.Callback.class);
stateController.addCallback(callback);
mExecutor.runAllReady();
// No home controls since it is not available.
assertThat(stateController.getComplications()).doesNotContain(homeControlsComplication);
stateController.setAvailableComplicationTypes(Complication.COMPLICATION_TYPE_HOME_CONTROLS
| Complication.COMPLICATION_TYPE_WEATHER);
mExecutor.runAllReady();
assertThat(stateController.getComplications()).contains(homeControlsComplication);
}
private DreamOverlayStateController getDreamOverlayStateController(boolean overlayEnabled) {
return new DreamOverlayStateController(mExecutor, overlayEnabled, mFeatureFlags);
}