Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Un-obscure the Telephony phone account ID.

Browse Source 
With the upcoming changes in T to move telephony phone account handles to
use subid instead of ICCID, the id of telephony phone account handles
no longer needs to be Log.pii-ed.  These phone accounts have been hard to
diagnose in most bug reports due to the obfuscation.

Bug: 226972613
Test: Manual testing; place calls and verify Telephony account handles are now visible.
Change-Id: I5ff66571658c2b81b83e3f7d1936e3e805598769
This commit is contained in:
Tyler Gunn
2022-03-28 09:22:41 -07:00
committed by Grace Jia
parent 3d790a1673
commit f601004255
1 changed files with 25 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
telecomm/java/android/telecom/PhoneAccountHandle.java
View File

@@ -46,6 +46,14 @@ import java.util.Objects;
* See {@link PhoneAccount}, {@link TelecomManager}.
*/
public final class PhoneAccountHandle implements Parcelable {
/**
* Expected component name of Telephony phone accounts; ONLY used to determine if we should log
* the phone account handle ID.
*/
private static final ComponentName TELEPHONY_COMPONENT_NAME =
new ComponentName("com.android.phone",
"com.android.services.telephony.TelephonyConnectionService");
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 127403196)
private final ComponentName mComponentName;
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 115609023)
@@ -136,14 +144,23 @@ public final class PhoneAccountHandle implements Parcelable {
@Override
public String toString() {
// Note: Log.pii called for mId as it can contain personally identifying phone account
// information such as SIP account IDs.
return new StringBuilder().append(mComponentName)
.append(", ")
.append(Log.pii(mId))
.append(", ")
.append(mUserHandle)
.toString();
StringBuilder sb = new StringBuilder()
.append(mComponentName)
.append(", ");
if (mComponentName.equals(TELEPHONY_COMPONENT_NAME)) {
// Telephony phone account handles are now keyed by subscription id which is not
// sensitive.
sb.append(mId);
} else {
// Note: Log.pii called for mId as it can contain personally identifying phone account
// information such as SIP account IDs.
sb.append(Log.pii(mId));
}
sb.append(", ");
sb.append(mUserHandle);
return sb.toString();
}
@Override