Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[incfs] Fix the unsafe memory copy in IncrementalService

Browse Source 
Better to protect the memcpy() and zero-out the target

Bug: 183160959
Test: atest IncrementalService
Change-Id: I3daca749168a8c5a32b1eedc7992006cbe2e9eb4
This commit is contained in:
Yurii Zubrytskyi
2021-03-18 19:29:19 -07:00
committed by Songchun Fan
parent 4375a74535
commit f5a6fb9996
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/incremental/BinderIncrementalService.cpp
View File

@@ -280,8 +280,8 @@ binder::Status BinderIncrementalService::getMetadataByPath(int32_t storageId,
}
static FileId toFileId(const std::vector<uint8_t>& id) {
FileId fid;
memcpy(&fid, id.data(), id.size());
FileId fid = {};
memcpy(&fid, id.data(), std::min(sizeof(fid), id.size()));
return fid;
}