Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Increase max shader cache size

Browse Source 
Bumps maxTotalSize (max size of the entire cache) to align with
the previous bump to maxValueSize (max size of an single entry in the
cache) in I1be3da0458c4b64f7082a2e1bc0d08b0824bbeba, which was discussed
on b/190348616. I chose 4 MiB here to keep the new values linearly
proportionate to their original values.

Note: this entire cache is stored in both RAM and flash. If 4 MiB is too
much, we could alternatively set maxTotalSize to 2 MiB and reduce
maxValueSize to 1 MiB (if maintaining the original proportions is
important).

Bug: 190348616
Test: builds (with new static_assert) and passes hwui_unit_tests
Change-Id: Ib101d1c432f3547483f52e64fad81bf0a1e20f07
This commit is contained in:
Nolan Scobie
2023-02-09 13:43:52 -05:00
parent 9a2b9d0800
commit f50917cd0a
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libs/hwui/pipeline/skia/ShaderCache.cpp
View File

@@ -33,7 +33,8 @@ namespace skiapipeline {
// Cache size limits.
static const size_t maxKeySize = 1024;
static const size_t maxValueSize = 2 * 1024 * 1024;
static const size_t maxTotalSize = 1024 * 1024;
static const size_t maxTotalSize = 4 * 1024 * 1024;
static_assert(maxKeySize + maxValueSize < maxTotalSize);
ShaderCache::ShaderCache() {
// There is an "incomplete FileBlobCache type" compilation error, if ctor is moved to header.