Don't kill apps for OP_REQUEST_INSTALL_PACKAGES on targetSdk < 26.

The app-op wasn't required back then, and granting it shouldn't change
the filesystem view.

Bug: 150819885
Test: atest CtsNoPermissiontestCases25 (still fails, but for a different
reason now).

Change-Id: Id505013233c44ad624d3a4b929bbd3c36ecfd8ce
This commit is contained in:
Martijn Coenen
2020-05-24 21:36:16 +02:00
parent 53392bb2a6
commit f488724013

View File

@@ -83,6 +83,7 @@ import android.content.res.ObbInfo;
import android.database.ContentObserver;
import android.net.Uri;
import android.os.Binder;
import android.os.Build;
import android.os.DropBoxManager;
import android.os.Environment;
import android.os.Handler;
@@ -4662,6 +4663,10 @@ class StorageManagerService extends IStorageManager.Stub
}
public void onAppOpsChanged(int code, int uid, @Nullable String packageName, int mode) {
if (packageName == null) {
// This happens :(
return;
}
final long token = Binder.clearCallingIdentity();
try {
if (mIsFuseEnabled) {
@@ -4669,7 +4674,20 @@ class StorageManagerService extends IStorageManager.Stub
switch(code) {
case OP_REQUEST_INSTALL_PACKAGES:
// Always kill regardless of op change, to remount apps /storage
killAppForOpChange(code, uid, packageName);
try {
ApplicationInfo ai = mIPackageManager.getApplicationInfo(
packageName,
0, UserHandle.getUserId(uid));
if (ai.targetSdkVersion >= Build.VERSION_CODES.O) {
killAppForOpChange(code, uid, packageName);
} else {
// Apps targeting <26 didn't need this app op to install
// packages - they only need the manifest permission, instead.
// So, there's also no need to kill them.
}
} catch (RemoteException e) {
// Ignore, this is an in-process call
}
return;
case OP_MANAGE_EXTERNAL_STORAGE:
if (mode != MODE_ALLOWED) {