Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only update the cached state if the value changed

Browse Source 
Test: atest BubblesTests
Bug: 242097561
Change-Id: Icaa37799741739121cc6d90da526bc9c9150c5ad
This commit is contained in:
Mady Mellor
2022-08-12 13:49:56 -07:00
parent 889241a5d8
commit f119f2712b
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleController.java
View File

@@ -1094,13 +1094,16 @@ public class BubbleController implements ConfigurationChangeListener {
}
void updateNotNotifyingEntry(Bubble b, BubbleEntry entry, boolean showInShade) {
boolean showInShadeBefore = b.showInShade();
boolean isBubbleSelected = Objects.equals(b, mBubbleData.getSelectedBubble());
boolean isBubbleExpandedAndSelected = isStackExpanded() && isBubbleSelected;
b.setEntry(entry);
boolean suppress = isBubbleExpandedAndSelected || !showInShade || !b.showInShade();
b.setSuppressNotification(suppress);
b.setShowDot(!isBubbleExpandedAndSelected);
mImpl.mCachedState.updateBubbleSuppressedState(b);
if (showInShadeBefore != b.showInShade()) {
mImpl.mCachedState.updateBubbleSuppressedState(b);
}
}
@VisibleForTesting