Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename AndroidFrameworkLintChecker's package to com.google.android.lint

Browse Source 
The previous package name com.android.lint is not allowed for custom
lint checks because lint thinks any package with com.android. is its own
API, so it performs a reflection check to see if it is a known API, but
it fails because it is a custom check.

For testing, verify that the lint report does not report an Obsolete
Custom Lint Check issue.

Bug: 192870410
Test: m out/soong/.intermediates/frameworks/base/services/autofill/services.autofill/android_common/lint/lint-report.html
Change-Id: I4970d230329a2ab48ec1c0152d824995fa005127
This commit is contained in:
Azhara Assanova
2021-07-19 10:30:18 +00:00
parent 3b7391c266
commit f0de8d34a3
3 changed files with 22 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tools/lint/checks/src/main/java/com/android/lint/CallingIdentityTokenDetector.kt → tools/lint/checks/src/main/java/com/google/android/lint/CallingIdentityTokenDetector.kt
View File

@@ -14,21 +14,21 @@
* limitations under the License.
*/
package com.android.lint
package com.google.android.lint
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_CLEAR_IDENTITY_CALL_NOT_FOLLOWED_BY_TRY_FINALLY
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_NESTED_CLEAR_IDENTITY_CALLS
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_NON_FINAL_TOKEN
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_RESTORE_IDENTITY_CALL_NOT_IN_FINALLY_BLOCK
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_UNUSED_TOKEN
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_USE_OF_CALLER_AWARE_METHODS_WITH_CLEARED_IDENTITY
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageClearIdentityCallNotFollowedByTryFinally
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageNestedClearIdentityCallsPrimary
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageNestedClearIdentityCallsSecondary
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageNonFinalToken
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageRestoreIdentityCallNotInFinallyBlock
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageUnusedToken
import com.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageUseOfCallerAwareMethodsWithClearedIdentity
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_CLEAR_IDENTITY_CALL_NOT_FOLLOWED_BY_TRY_FINALLY
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_NESTED_CLEAR_IDENTITY_CALLS
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_NON_FINAL_TOKEN
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_RESTORE_IDENTITY_CALL_NOT_IN_FINALLY_BLOCK
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_UNUSED_TOKEN
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.ISSUE_USE_OF_CALLER_AWARE_METHODS_WITH_CLEARED_IDENTITY
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageClearIdentityCallNotFollowedByTryFinally
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageNestedClearIdentityCallsPrimary
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageNestedClearIdentityCallsSecondary
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageNonFinalToken
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageRestoreIdentityCallNotInFinallyBlock
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageUnusedToken
import com.google.android.lint.CallingIdentityTokenIssueRegistry.Companion.getIncidentMessageUseOfCallerAwareMethodsWithClearedIdentity
import com.android.tools.lint.client.api.UElementHandler
import com.android.tools.lint.detector.api.Context
import com.android.tools.lint.detector.api.Detector

16
tools/lint/checks/src/main/java/com/android/lint/CallingIdentityTokenIssueRegistry.kt → tools/lint/checks/src/main/java/com/google/android/lint/CallingIdentityTokenIssueRegistry.kt
View File

@@ -14,11 +14,10 @@
* limitations under the License.
*/
package com.android.lint
package com.google.android.lint
import com.android.tools.lint.client.api.IssueRegistry
// TODO: uncomment when lint API in Soong becomes 30.0+
// import com.android.tools.lint.client.api.Vendor
import com.android.tools.lint.client.api.Vendor
import com.android.tools.lint.detector.api.CURRENT_API
import com.android.tools.lint.detector.api.Category
import com.android.tools.lint.detector.api.Implementation
@@ -45,12 +44,11 @@ class CallingIdentityTokenIssueRegistry : IssueRegistry() {
override val minApi: Int
get() = 8
// TODO: uncomment when lint API in Soong becomes 30.0+
// override val vendor: Vendor = Vendor(
// vendorName = "Android Open Source Project",
// feedbackUrl = "http://b/issues/new?component=315013",
// contact = "brufino@google.com"
// )
override val vendor: Vendor = Vendor(
vendorName = "Android",
feedbackUrl = "http://b/issues/new?component=315013",
contact = "brufino@google.com"
)
companion object {
/** Issue: unused token from Binder.clearCallingIdentity() */

2
tools/lint/checks/src/test/java/com/android/lint/CallingIdentityTokenDetectorTest.kt → tools/lint/checks/src/test/java/com/google/android/lint/CallingIdentityTokenDetectorTest.kt
View File

@@ -14,7 +14,7 @@
* limitations under the License.
*/
package com.android.lint
package com.google.android.lint
import com.android.tools.lint.checks.infrastructure.LintDetectorTest
import com.android.tools.lint.checks.infrastructure.TestFile