Remove redundant TODOs from PackageTracker
The permission checks are either not required (for the data app)
or have been moved to validateUpdaterAppManifest()
(for the updater app).
Bug: 64142062
Test: make droid
Change-Id: Ie1791d64484f53ea2c2476f866fbd75358960de3
(cherry picked from commit 6f14377e21)
This commit is contained in:
@@ -173,8 +173,6 @@ public class PackageTracker implements IntentHelper.Listener {
|
||||
throw logAndThrowRuntimeException("Could not determine update app package details for "
|
||||
+ mUpdateAppPackageName, e);
|
||||
}
|
||||
// TODO(nfuller) Consider permission checks. While an updated system app retains permissions
|
||||
// obtained by the system version it's not clear how to check them.
|
||||
Slog.d(TAG, "Update app " + mUpdateAppPackageName + " is valid.");
|
||||
|
||||
// Validate the data application package.
|
||||
@@ -187,8 +185,6 @@ public class PackageTracker implements IntentHelper.Listener {
|
||||
throw logAndThrowRuntimeException("Could not determine data app package details for "
|
||||
+ mDataAppPackageName, e);
|
||||
}
|
||||
// TODO(nfuller) Consider permission checks. While an updated system app retains permissions
|
||||
// obtained by the system version it's not clear how to check them.
|
||||
Slog.d(TAG, "Data app " + mDataAppPackageName + " is valid.");
|
||||
}
|
||||
|
||||
@@ -466,7 +462,6 @@ public class PackageTracker implements IntentHelper.Listener {
|
||||
+ TimeZoneRulesDataContract.AUTHORITY);
|
||||
return false;
|
||||
}
|
||||
// TODO(nfuller) Add any permissions checks needed.
|
||||
return true;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user