Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Just get VoiceInteractionManagerService once in Activity.java

Browse Source 
During testing the testActivityTransitionsAnimation, it usually
takes 400us ~ 1ms to get the VoiceInteractionManagerService, it
would be better to get VoiceInteractionManagerService once
and keep it instead of getting VoiceInteractionManagerService
again in the other stages.

Test: atest CtsVoiceInteractionTestCases
Bug: 261791888
Change-Id: I46daa11f2281a8db96056ca99520a0c3fe41e4ec
This commit is contained in:
lpeter
2022-11-22 07:44:58 +08:00
parent e2c82f46d7
commit efc66d30ab
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
core/java/android/app/Activity.java
View File

@@ -1010,6 +1010,8 @@ public class Activity extends ContextThemeWrapper
private ComponentCallbacksController mCallbacksController;
@Nullable private IVoiceInteractionManagerService mVoiceInteractionManagerService;
private final WindowControllerCallback mWindowControllerCallback =
new WindowControllerCallback() {
/**
@@ -1619,18 +1621,17 @@ public class Activity extends ContextThemeWrapper
private void notifyVoiceInteractionManagerServiceActivityEvent(
@VoiceInteractionSession.VoiceInteractionActivityEventType int type) {
final IVoiceInteractionManagerService service =
IVoiceInteractionManagerService.Stub.asInterface(
ServiceManager.getService(Context.VOICE_INTERACTION_MANAGER_SERVICE));
if (service == null) {
Log.w(TAG, "notifyVoiceInteractionManagerServiceActivityEvent: Can not get "
+ "VoiceInteractionManagerService");
return;
if (mVoiceInteractionManagerService == null) {
mVoiceInteractionManagerService = IVoiceInteractionManagerService.Stub.asInterface(
ServiceManager.getService(Context.VOICE_INTERACTION_MANAGER_SERVICE));
if (mVoiceInteractionManagerService == null) {
Log.w(TAG, "notifyVoiceInteractionManagerServiceActivityEvent: Can not get "
+ "VoiceInteractionManagerService");
return;
}
}
try {
service.notifyActivityEventChanged(mToken, type);
mVoiceInteractionManagerService.notifyActivityEventChanged(mToken, type);
} catch (RemoteException e) {
// Empty
}