Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MediaRouter: Update discovery request for unregister

Browse Source 
When a router is unregistered, update composite discovery request.
Add bug ID for some TODOs.

Bug: 152952973
Test: cts and atest mediaroutertest
Change-Id: If5193c4be5d7ff4917e3a2ced52999123bc35743
This commit is contained in:
Kyunglyul Hyun
2020-04-01 22:15:08 +09:00
parent 815543b3a1
commit ef7e88f035
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
services/core/java/com/android/server/media/MediaRouter2ServiceImpl.java
View File

@@ -493,7 +493,7 @@ class MediaRouter2ServiceImpl {
}
}
//TODO: Review this is handling multi-user properly.
//TODO(b/136703681): Review this is handling multi-user properly.
void switchUser() {
synchronized (mLock) {
int userId = ActivityManager.getCurrentUser();
@@ -568,7 +568,9 @@ class MediaRouter2ServiceImpl {
UserRecord userRecord = routerRecord.mUserRecord;
userRecord.mRouterRecords.remove(routerRecord);
//TODO: update discovery request
userRecord.mHandler.sendMessage(
obtainMessage(UserHandler::updateDiscoveryPreferenceOnHandler,
userRecord.mHandler));
routerRecord.dispose();
disposeUserIfNeededLocked(userRecord); // since router removed from user
}
@@ -793,7 +795,7 @@ class MediaRouter2ServiceImpl {
}
long uniqueRequestId = toUniqueRequestId(managerRecord.mManagerId, requestId);
//TODO: Use MediaRouter2's OnCreateSessionListener to send proper session hints.
//TODO(b/152851868): Use MediaRouter2's OnCreateSessionListener to send session hints.
routerRecord.mUserRecord.mHandler.sendMessage(
obtainMessage(UserHandler::requestCreateSessionOnHandler,
routerRecord.mUserRecord.mHandler,
@@ -1146,7 +1148,6 @@ class MediaRouter2ServiceImpl {
return mSessionToRouterMap.get(uniqueSessionId);
}
//TODO: notify session info updates
private void onProviderStateChangedOnHandler(@NonNull MediaRoute2Provider provider) {
int providerInfoIndex = getLastProviderInfoIndex(provider.getUniqueId());
MediaRoute2ProviderInfo providerInfo = provider.getProviderInfo();
@@ -1319,7 +1320,7 @@ class MediaRouter2ServiceImpl {
return true;
}
//TODO: Handle RCN case.
//TODO(b/152950479): Handle RCN case.
if (routerRecord == null) {
Slog.w(TAG, "Ignoring " + description + " route from unknown router.");
return false;