Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove tracing for notifyContentCapture

Browse Source 
These traces get expensive in aggregate due to an increased number of
notifyContentCapture events.  Remove them.

Bug 188836620
Test:  Confirmed no notifyContentCapture trace points in systrace

Change-Id: I5d77bd9048b2e8cd267187f866dc095792a3f455
This commit is contained in:
Philip Cuadra
2021-06-07 17:21:37 -07:00
parent d8be4517b3
commit ef671105e1
1 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
core/java/android/view/View.java
View File

@@ -9808,23 +9808,9 @@ public class View implements Drawable.Callback, KeyEvent.Callback,
*/
private void notifyAppearedOrDisappearedForContentCaptureIfNeeded(boolean appeared) {
AttachInfo ai = mAttachInfo;
// Skip it while the view is being laided out for the first time
// Skip it while the view is being laid out for the first time
if (ai != null && !ai.mReadyForContentCaptureUpdates) return;
if (Trace.isTagEnabled(Trace.TRACE_TAG_VIEW)) {
Trace.traceBegin(Trace.TRACE_TAG_VIEW,
"notifyContentCapture(" + appeared + ") for " + getClass().getSimpleName());
}
try {
notifyAppearedOrDisappearedForContentCaptureIfNeededNoTrace(appeared);
} finally {
Trace.traceEnd(Trace.TRACE_TAG_VIEW);
}
}
private void notifyAppearedOrDisappearedForContentCaptureIfNeededNoTrace(boolean appeared) {
AttachInfo ai = mAttachInfo;
// First check if context has client, so it saves a service lookup when it doesn't
if (mContext.getContentCaptureOptions() == null) return;