Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Visit URIs in themed remoteviews icons." into sc-dev

Browse Source
This commit is contained in:
Treehugger Robot
2023-05-30 20:08:15 +00:00
committed by Android (Google) Code Review
parent b40db93ccc 634a69b770
commit ee97e94714
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/java/android/widget/RemoteViews.java
View File

@@ -1749,7 +1749,7 @@ public class RemoteViews implements Parcelable, Filter {
} }
@Override @Override
public final void visitUris(@NonNull Consumer<Uri> visitor) { public void visitUris(@NonNull Consumer<Uri> visitor) {
switch (this.type) { switch (this.type) {
case URI: case URI:
final Uri uri = (Uri) getParameterValue(null); final Uri uri = (Uri) getParameterValue(null);
@@ -2201,6 +2201,14 @@ public class RemoteViews implements Parcelable, Filter {
public int getActionTag() { public int getActionTag() {
return NIGHT_MODE_REFLECTION_ACTION_TAG; return NIGHT_MODE_REFLECTION_ACTION_TAG;
} }
@Override
public void visitUris(@NonNull Consumer<Uri> visitor) {
if (this.type == ICON) {
visitIconUri((Icon) mDarkValue, visitor);
visitIconUri((Icon) mLightValue, visitor);
}
}
} }
/** /**

13
core/tests/coretests/src/android/widget/RemoteViewsTest.java
View File

@@ -530,6 +530,19 @@ public class RemoteViewsTest {
verify(visitor, times(1)).accept(eq(icon4.getUri())); verify(visitor, times(1)).accept(eq(icon4.getUri()));
} }
@Test
public void visitUris_themedIcons() {
RemoteViews views = new RemoteViews(mPackage, R.layout.remote_views_test);
final Icon iconLight = Icon.createWithContentUri("content://light/icon");
final Icon iconDark = Icon.createWithContentUri("content://dark/icon");
views.setIcon(R.id.layout, "setLargeIcon", iconLight, iconDark);
Consumer<Uri> visitor = (Consumer<Uri>) spy(Consumer.class);
views.visitUris(visitor);
verify(visitor, times(1)).accept(eq(iconLight.getUri()));
verify(visitor, times(1)).accept(eq(iconDark.getUri()));
}
@Test @Test
public void visitUris_nestedViews() { public void visitUris_nestedViews() {
final RemoteViews outer = new RemoteViews(mPackage, R.layout.remote_views_test); final RemoteViews outer = new RemoteViews(mPackage, R.layout.remote_views_test);