Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Visit URIs in themed remoteviews icons.

Browse Source 
Bug: 281018094
Test: atest RemoteViewsTest NotificationVisitUrisTest
Change-Id: I2014bf21cf90267f7f1b3f370bf00ab7001b064e
Merged-In: I2014bf21cf90267f7f1b3f370bf00ab7001b064e
This commit is contained in:
Ioana Alexandru
2023-05-25 11:43:43 +00:00
parent b50f8cd595
commit 634a69b770
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/java/android/widget/RemoteViews.java
View File

@@ -1744,7 +1744,7 @@ public class RemoteViews implements Parcelable, Filter {
}
@Override
public final void visitUris(@NonNull Consumer<Uri> visitor) {
public void visitUris(@NonNull Consumer<Uri> visitor) {
switch (this.type) {
case URI:
final Uri uri = (Uri) getParameterValue(null);
@@ -2196,6 +2196,14 @@ public class RemoteViews implements Parcelable, Filter {
public int getActionTag() {
return NIGHT_MODE_REFLECTION_ACTION_TAG;
}
@Override
public void visitUris(@NonNull Consumer<Uri> visitor) {
if (this.type == ICON) {
visitIconUri((Icon) mDarkValue, visitor);
visitIconUri((Icon) mLightValue, visitor);
}
}
}
/**

13
core/tests/coretests/src/android/widget/RemoteViewsTest.java
View File

@@ -528,6 +528,19 @@ public class RemoteViewsTest {
verify(visitor, times(1)).accept(eq(icon4.getUri()));
}
@Test
public void visitUris_themedIcons() {
RemoteViews views = new RemoteViews(mPackage, R.layout.remote_views_test);
final Icon iconLight = Icon.createWithContentUri("content://light/icon");
final Icon iconDark = Icon.createWithContentUri("content://dark/icon");
views.setIcon(R.id.layout, "setLargeIcon", iconLight, iconDark);
Consumer<Uri> visitor = (Consumer<Uri>) spy(Consumer.class);
views.visitUris(visitor);
verify(visitor, times(1)).accept(eq(iconLight.getUri()));
verify(visitor, times(1)).accept(eq(iconDark.getUri()));
}
@Test
public void visitUris_nestedViews() {
final RemoteViews outer = new RemoteViews(mPackage, R.layout.remote_views_test);