Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent NPE in MediaRouter2ServiceImpl#dump

Browse Source 
Replaces a use of get (expects the id) with valueAt, which
expects an index.

Also simplify anonymous runnable by using a lambda.

Bug: 243116883
Test: adb shell dumpsys media_router
Change-Id: Ib84a58bf1675ef2e60ca384a8e617e27f4ddd7de
This commit is contained in:
Santiago Seifert
2022-09-22 19:08:27 +00:00
parent 4f31d4f95d
commit ee516e366d
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
services/core/java/com/android/server/media/MediaRouter2ServiceImpl.java
View File

@@ -613,7 +613,7 @@ class MediaRouter2ServiceImpl {
pw.println(indent + "UserRecords:");
if (mUserRecords.size() > 0) {
for (int i = 0; i < mUserRecords.size(); i++) {
mUserRecords.get(i).dump(pw, indent + " ");
mUserRecords.valueAt(i).dump(pw, indent + " ");
}
} else {
pw.println(indent + "<no user records>");
@@ -1243,12 +1243,7 @@ class MediaRouter2ServiceImpl {
pw.println(indent + "<no manager records>");
}
if (!mHandler.runWithScissors(new Runnable() {
@Override
public void run() {
mHandler.dump(pw, indent);
}
}, 1000)) {
if (!mHandler.runWithScissors(() -> mHandler.dump(pw, indent), 1000)) {
pw.println(indent + "<could not dump handler state>");
}
}