Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Un-@Ignore 7 passing ChooserActivity tests.

Browse Source 
Of 69 ChooserActivityTest cases, 22 are currently
ignored, but should be restored in order to maximize
coverage in preparation for the new unbundled
implementation (but note that these tests are still
only run against the "bundled" system chooser for now).

Of the 22 ignored tests, 7 of them pass reliably and can
be un-ignored immediately (although it's not known whether
they were ignored for a reason other than failures/flakes).
The remaining 15 will require some changes to the test
and/or ChooserActivity code, to be investigated & completed
in future CLs.

Bug: 208803748
Test: `atest --iterations 100 ChooserActivityTest` (100
iterations ensures no regressions-to-flakiness.)

Change-Id: Iede5835b429cccfd65fdc114397460fc00781a75
This commit is contained in:
Joshua Trask
2021-12-01 17:16:13 -05:00
parent b9c9a4a068
commit ec29931867
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
core/tests/coretests/src/com/android/internal/app/ChooserActivityTest.java
View File

@@ -269,7 +269,7 @@ public class ChooserActivityTest {
onView(withId(R.id.content_preview_thumbnail)).check(matches(isDisplayed()));
}
@Test @Ignore
@Test
public void twoOptionsAndUserSelectsOne() throws InterruptedException {
Intent sendIntent = createSendTextIntent();
List<ResolvedComponentInfo> resolvedComponentInfos = createResolvedComponentsForTest(2);
@@ -298,7 +298,7 @@ public class ChooserActivityTest {
assertThat(chosen[0], is(toChoose));
}
@Test @Ignore
@Test
public void fourOptionsStackedIntoOneTarget() throws InterruptedException {
Intent sendIntent = createSendTextIntent();
@@ -351,7 +351,7 @@ public class ChooserActivityTest {
}
}
@Test @Ignore
@Test
public void updateChooserCountsAndModelAfterUserSelection() throws InterruptedException {
Intent sendIntent = createSendTextIntent();
List<ResolvedComponentInfo> resolvedComponentInfos = createResolvedComponentsForTest(2);
@@ -461,7 +461,7 @@ public class ChooserActivityTest {
assertThat(chosen[0], is(toChoose));
}
@Test @Ignore
@Test
public void hasOtherProfileTwoOptionsAndUserSelectsOne() throws Exception {
// enable the work tab feature flag
ResolverActivity.ENABLE_TABBED_VIEW = true;
@@ -500,7 +500,7 @@ public class ChooserActivityTest {
assertThat(chosen[0], is(toChoose));
}
@Test @Ignore
@Test
public void hasLastChosenActivityAndOtherProfile() throws Exception {
// enable the work tab feature flag
ResolverActivity.ENABLE_TABBED_VIEW = true;
@@ -1549,7 +1549,7 @@ public class ChooserActivityTest {
assertThat(activity.getWorkListAdapter().getCount(), is(workProfileTargets));
}
@Test @Ignore
@Test
public void testWorkTab_selectingWorkTabAppOpensAppInWorkProfile() throws InterruptedException {
// enable the work tab feature flag
ResolverActivity.ENABLE_TABBED_VIEW = true;
@@ -1947,7 +1947,7 @@ public class ChooserActivityTest {
.SharesheetTargetSelectedEvent.SHARESHEET_COPY_TARGET_SELECTED.getId()));
}
@Test @Ignore
@Test
public void testSwitchProfileLogging() throws InterruptedException {
// enable the work tab feature flag
ResolverActivity.ENABLE_TABBED_VIEW = true;