Merge changes I313240f1,Ie2b830d0 into udc-qpr-dev

* changes:
  Remove setalpha(0f) from reset.
  Revert "Fix user switcher flicker."
This commit is contained in:
Aaron Liu
2023-08-08 15:59:16 +00:00
committed by Android (Google) Code Review
4 changed files with 21 additions and 3 deletions

View File

@@ -1197,8 +1197,6 @@ public class KeyguardSecurityContainer extends ConstraintLayout {
});
mPopup.show();
});
mUserSwitcherViewGroup.setAlpha(0f);
}
@Override

View File

@@ -675,6 +675,14 @@ public class KeyguardSecurityContainerController extends ViewController<Keyguard
mSecurityViewFlipperController.reset();
}
/** Prepares views in the bouncer before starting appear animation. */
public void prepareToShow() {
View bouncerUserSwitcher = mView.findViewById(R.id.keyguard_bouncer_user_switcher);
if (bouncerUserSwitcher != null) {
bouncerUserSwitcher.setAlpha(0f);
}
}
@Override
public void onResume(int reason) {
if (DEBUG) Log.d(TAG, "screen on, instance " + Integer.toHexString(hashCode()));

View File

@@ -121,7 +121,7 @@ object KeyguardBouncerViewBinder {
view.visibility = if (isShowing) View.VISIBLE else View.INVISIBLE
if (isShowing) {
// Reset security container because these views are not reinflated.
securityContainerController.reset()
securityContainerController.prepareToShow()
securityContainerController.reinflateViewFlipper {
// Reset Security Container entirely.
securityContainerController.onBouncerVisibilityChanged(

View File

@@ -27,6 +27,7 @@ import android.testing.TestableResources
import android.view.Gravity
import android.view.LayoutInflater
import android.view.MotionEvent
import android.view.View
import android.view.WindowInsetsController
import android.widget.FrameLayout
import androidx.test.filters.SmallTest
@@ -83,6 +84,7 @@ import org.mockito.Captor
import org.mockito.Mock
import org.mockito.Mockito.atLeastOnce
import org.mockito.Mockito.clearInvocations
import org.mockito.Mockito.mock
import org.mockito.Mockito.never
import org.mockito.Mockito.spy
import org.mockito.Mockito.verify
@@ -837,6 +839,16 @@ class KeyguardSecurityContainerControllerTest : SysuiTestCase() {
verify(viewMediatorCallback).keyguardDone(anyBoolean(), anyInt())
}
@Test
fun testResetUserSwitcher() {
val userSwitcher = mock(View::class.java)
whenever(view.findViewById<View>(R.id.keyguard_bouncer_user_switcher))
.thenReturn(userSwitcher)
underTest.prepareToShow()
verify(userSwitcher).setAlpha(0f)
}
private val registeredSwipeListener: KeyguardSecurityContainer.SwipeListener
get() {
underTest.onViewAttached()