Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make SmartReplyConstants thread-safe.

Browse Source 
To be able to move smart reply view inflations off the UI thread we need
to access SmartReplyConstants on a background thread. Thus, in this CL we
make SmartReplyConstants thread-safe.

Bug: 119801785
Test: none
Change-Id: Ib62fc078fcb05ec4795a29836d5b10443516ca8e
This commit is contained in:
Gustav Sennton
2019-02-25 18:44:01 +00:00
parent fd25fe1206
commit eb93c4024a
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/SystemUI/src/com/android/systemui/statusbar/policy/SmartReplyConstants.java
View File

@@ -57,13 +57,17 @@ public final class SmartReplyConstants extends ContentObserver {
private final int mDefaultMinNumSystemGeneratedReplies;
private final int mDefaultMaxNumActions;
private boolean mEnabled;
private boolean mRequiresTargetingP;
private int mMaxSqueezeRemeasureAttempts;
private boolean mEditChoicesBeforeSending;
private boolean mShowInHeadsUp;
private int mMinNumSystemGeneratedReplies;
private int mMaxNumActions;
// These fields are updated on the UI thread but can be accessed on both the UI thread and
// background threads. We use the volatile keyword here instead of synchronization blocks since
// we only care about variable updates here being visible to other threads (and not for example
// whether the variables we are reading were updated in the same go).
private volatile boolean mEnabled;
private volatile boolean mRequiresTargetingP;
private volatile int mMaxSqueezeRemeasureAttempts;
private volatile boolean mEditChoicesBeforeSending;
private volatile boolean mShowInHeadsUp;
private volatile int mMinNumSystemGeneratedReplies;
private volatile int mMaxNumActions;
private final Context mContext;
private final KeyValueListParser mParser = new KeyValueListParser(',');