Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Dark-greylists fill() methods in ListView and GridView

Browse Source 
These methods shouldn't be reflected on - and I'm not sure that there is
a valid reason for doing so. For anything more complex than what ListView /
GridView provide out of the box, developers should use and customize
RecyclerView.

Bug: b/123768638
Bug: b/123768419
Bug: b/123768563
Bug: b/123768501
Bug: b/123768701
Test: n/a
Change-Id: Ie13aa728832c085388322828320ba934415bd9e2
This commit is contained in:
Louis Pullen-Freilich
2019-02-06 14:06:03 +00:00
parent e8c4958b2f
commit e6f939530c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/java/android/widget/GridView.java
View File

@@ -310,7 +310,7 @@ public class GridView extends AbsListView {
* @return The view that is currently selected, if it happens to be in the
* range that we draw.
*/
@UnsupportedAppUsage
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)
private View fillDown(int pos, int nextTop) {
View selectedView = null;
@@ -410,7 +410,7 @@ public class GridView extends AbsListView {
*
* @return The view that is currently selected
*/
@UnsupportedAppUsage
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)
private View fillUp(int pos, int nextBottom) {
View selectedView = null;

6
core/java/android/widget/ListView.java
View File

@@ -780,7 +780,7 @@ public class ListView extends AbsListView {
* @return The view that is currently selected, if it happens to be in the
* range that we draw.
*/
@UnsupportedAppUsage
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)
private View fillDown(int pos, int nextTop) {
View selectedView = null;
@@ -815,7 +815,7 @@ public class ListView extends AbsListView {
*
* @return The view that is currently selected
*/
@UnsupportedAppUsage
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)
private View fillUp(int pos, int nextBottom) {
View selectedView = null;
@@ -1488,7 +1488,7 @@ public class ListView extends AbsListView {
* @return The selected view, or null if the selected view is outside the
* visible area.
*/
@UnsupportedAppUsage
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P)
private View fillSpecific(int position, int top) {
boolean tempIsSelected = position == mSelectedPosition;
View temp = makeAndAddView(position, top, true, mListPadding.left, tempIsSelected);