Remove duplicate call to update PIP bounds on PIP expand

Remove the callback to update bounds in
resizeAndAnimatePipUnchecked because:
1. animateResizePip already attaches a callback to update the
bounds state in onAnimationEnd
2. it updates the bounds too early before finishResize() is
called, which causes finishResize() to not know the pre-resize
bounds needed to perform the crossfade animation

Bug: 188829986
Test: enter PIP with seamless resize turned on, double-tap to
expand and unexpand, crossfade animation looks right

Change-Id: Id64222fe762b4db0d9ea739db434e8e6acb0b31a
This commit is contained in:
jorgegil@google.com
2021-05-21 10:44:43 -07:00
parent fe788b0b7b
commit e5f4c32ce8
2 changed files with 2 additions and 1 deletions

View File

@@ -202,6 +202,7 @@ public class PhonePipMenuController implements PipMenuController {
mSystemWindows.updateViewLayout(mPipMenuView,
getPipMenuLayoutParams(MENU_WINDOW_TITLE, destinationBounds.width(),
destinationBounds.height()));
updateMenuLayout(destinationBounds);
}
/**

View File

@@ -684,7 +684,7 @@ public class PipMotionHelper implements PipAppOpsListener.Callback,
// Intentionally resize here even if the current bounds match the destination bounds.
// This is so all the proper callbacks are performed.
mPipTaskOrganizer.scheduleAnimateResizePip(toBounds, duration,
TRANSITION_DIRECTION_EXPAND_OR_UNEXPAND, mUpdateBoundsCallback);
TRANSITION_DIRECTION_EXPAND_OR_UNEXPAND, null /* updateBoundsCallback */);
setAnimatingToBounds(toBounds);
}