Revert "Revert "Fixed animation breakage when QS area tapped during expand/collapse""
This reverts commit b590a6fa4e.
Reason for revert: Applying fix and relanding
Test: manual & tablet scenario tests to confirm split shade unaffected
Change-Id: If4f59e5a20e5fcdcbd81b8ecb29741741818ce8d
This commit is contained in:
@@ -2072,6 +2072,14 @@ public final class NotificationPanelViewController implements Dumpable {
|
||||
mInitialTouchX = x;
|
||||
initVelocityTracker();
|
||||
trackMovement(event);
|
||||
float qsExpansionFraction = computeQsExpansionFraction();
|
||||
// Intercept the touch if QS is between fully collapsed and fully expanded state
|
||||
if (!mSplitShadeEnabled
|
||||
&& qsExpansionFraction > 0.0 && qsExpansionFraction < 1.0) {
|
||||
mShadeLog.logMotionEvent(event,
|
||||
"onQsIntercept: down action, QS partially expanded/collapsed");
|
||||
return true;
|
||||
}
|
||||
if (mKeyguardShowing
|
||||
&& shouldQuickSettingsIntercept(mInitialTouchX, mInitialTouchY, 0)) {
|
||||
// Dragging down on the lockscreen statusbar should prohibit other interactions
|
||||
@@ -2324,6 +2332,14 @@ public final class NotificationPanelViewController implements Dumpable {
|
||||
if (!isFullyCollapsed()) {
|
||||
handleQsDown(event);
|
||||
}
|
||||
// defer touches on QQS to shade while shade is collapsing. Added margin for error
|
||||
// as sometimes the qsExpansionFraction can be a tiny value instead of 0 when in QQS.
|
||||
if (!mSplitShadeEnabled
|
||||
&& computeQsExpansionFraction() <= 0.01 && getExpandedFraction() < 1.0) {
|
||||
mShadeLog.logMotionEvent(event,
|
||||
"handleQsTouch: QQS touched while shade collapsing");
|
||||
mQsTracking = false;
|
||||
}
|
||||
if (!mQsExpandImmediate && mQsTracking) {
|
||||
onQsTouch(event);
|
||||
if (!mConflictingQsExpansionGesture && !mSplitShadeEnabled) {
|
||||
@@ -2564,7 +2580,6 @@ public final class NotificationPanelViewController implements Dumpable {
|
||||
// Reset scroll position and apply that position to the expanded height.
|
||||
float height = mQsExpansionHeight;
|
||||
setQsExpansionHeight(height);
|
||||
updateExpandedHeightToMaxHeight();
|
||||
mNotificationStackScrollLayoutController.checkSnoozeLeavebehind();
|
||||
|
||||
// When expanding QS, let's authenticate the user if possible,
|
||||
|
||||
Reference in New Issue
Block a user