Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Adds synchronization around message handler in GeolocationPermissions and WebStorage

Browse Source 
The message handler is instantiated on the WebCore thread and its presence is
checked on the browser thread. This requires synchronization.

Change-Id: I4b71c7a2470b60fa273dc2bcb46f645ed135ee11
This commit is contained in:
Steve Block
2010-02-19 12:21:35 +00:00
parent 4b9f74a2d3
commit e4b2d4dc7d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/java/android/webkit/GeolocationPermissions.java
View File

@@ -126,7 +126,7 @@ public final class GeolocationPermissions {
* Creates the message handler. Must be called on the WebKit thread.
* @hide
*/
public void createHandler() {
public synchronized void createHandler() {
if (mHandler == null) {
mHandler = new Handler() {
@Override
@@ -180,7 +180,7 @@ public final class GeolocationPermissions {
/**
* Utility function to send a message to our handler.
*/
private void postMessage(Message msg) {
private synchronized void postMessage(Message msg) {
assert(mHandler != null);
mHandler.sendMessage(msg);
}

4
core/java/android/webkit/WebStorage.java
View File

@@ -146,7 +146,7 @@ public final class WebStorage {
* @hide
* Message handler, webcore side
*/
public void createHandler() {
public synchronized void createHandler() {
if (mHandler == null) {
mHandler = new Handler() {
@Override
@@ -342,7 +342,7 @@ public final class WebStorage {
/**
* Utility function to send a message to our handler
*/
private void postMessage(Message msg) {
private synchronized void postMessage(Message msg) {
if (mHandler != null) {
mHandler.sendMessage(msg);
}