Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Partially revert the usage of string enum.

Browse Source 
There's a regression in showmap_rss_bytes, after looking into the whole
showmap, the increase mostly came from framework, after partially revert
the usage of string enum, the showmap_rss_bytes number seems to decrease
consistently.

Bug: b/289956225
Bug: b/283858001
Test: forrest test
Change-Id: I3f548ac2bc437394d7da7d0a88090dd3aa27d7f8
This commit is contained in:
Peiyong Lin
2023-07-08 22:20:36 +00:00
parent abeaa64df5
commit e4a5cdbd95
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
core/java/android/os/GraphicsEnvironment.java
View File

@@ -112,16 +112,14 @@ public class GraphicsEnvironment {
private static final int ANGLE_GL_DRIVER_ALL_ANGLE_OFF = 0;
// Values for ANGLE_GL_DRIVER_SELECTION_VALUES
private static final String ANGLE_GL_DRIVER_CHOICE_DEFAULT = "default";
private static final String ANGLE_GL_DRIVER_CHOICE_ANGLE = "angle";
private static final String ANGLE_GL_DRIVER_CHOICE_NATIVE = "native";
private enum AngleDriverChoice {
DEFAULT("default"),
ANGLE("angle"),
NATIVE("native");
public final String choice;
AngleDriverChoice(String choice) {
this.choice = choice;
}
DEFAULT,
ANGLE,
NATIVE,
}
private static final String PROPERTY_RO_ANGLE_SUPPORTED = "ro.gfx.angle.supported";
@@ -493,9 +491,9 @@ public class GraphicsEnvironment {
Log.v(TAG,
"ANGLE Developer option for '" + packageName + "' "
+ "set to: '" + optInValue + "'");
if (optInValue.equals(AngleDriverChoice.ANGLE.choice)) {
if (optInValue.equals(ANGLE_GL_DRIVER_CHOICE_ANGLE)) {
return AngleDriverChoice.ANGLE;
} else if (optInValue.equals(AngleDriverChoice.NATIVE.choice)) {
} else if (optInValue.equals(ANGLE_GL_DRIVER_CHOICE_NATIVE)) {
return AngleDriverChoice.NATIVE;
} else {
// The user either chose default or an invalid value; go with the default driver or what