Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unnecessary check and prevent unnecessary log

Browse Source 
.. while getting a valid root task.

Bug: 184806710
Test: wm presubmit
Change-Id: I8d6a0f5f928dffec4f2371988c5807aad370289b
This commit is contained in:
Louis Chang
2022-03-22 11:46:57 +08:00
parent fdd691c352
commit e3719bdc6b
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
services/core/java/com/android/server/wm/ActivityStarter.java
View File

@@ -2686,11 +2686,8 @@ class ActivityStarter {
// launched into the same root task.
mTargetRootTask = Task.fromWindowContainerToken(mSourceRecord.mLaunchRootTask);
} else {
final Task rootTask =
getOrCreateRootTask(mStartActivity, mLaunchFlags, intentTask, mOptions);
// TODO(b/184806710): #getOrCreateRootTask should never return null?
mTargetRootTask =
rootTask != null ? rootTask : intentActivity.getRootTask();
mTargetRootTask = getOrCreateRootTask(mStartActivity, mLaunchFlags, intentTask,
mOptions);
}
}

2
services/core/java/com/android/server/wm/RootWindowContainer.java
View File

@@ -2754,7 +2754,7 @@ class RootWindowContainer extends WindowContainer<DisplayContent>
// First preference goes to the launch root task set in the activity options.
if (options != null) {
final Task candidateRoot = Task.fromWindowContainerToken(options.getLaunchRootTask());
if (canLaunchOnDisplay(r, candidateRoot)) {
if (candidateRoot != null && canLaunchOnDisplay(r, candidateRoot)) {
return candidateRoot;
}
}