Change the create passkey subtitle to <Passkey - subtitle>

screenshot: https://screenshot.googleplex.com/tyiEa9ghceKyxtW

Test: deployed locally

Bug: 253157211
Change-Id: Idc821ac6b760e557a1888d5e6be4147b5334c9b7
This commit is contained in:
Qinmei Du
2022-11-23 22:56:00 +00:00
parent 73c1612658
commit e3536fc1d5
3 changed files with 38 additions and 19 deletions

View File

@@ -34,6 +34,7 @@
<string name="passkey">passkey</string>
<string name="password">password</string>
<string name="sign_ins">sign-ins</string>
<string name="passkey_before_subtitle">Passkey</string>
<string name="another_device">Another device</string>
<string name="other_password_manager">Other password managers</string>
<!-- TODO: Check the wording here. -->

View File

@@ -576,24 +576,42 @@ fun PrimaryCreateOptionRow(
label = {
Column() {
// TODO: Add the function to hide/view password when the type is create password
if (requestDisplayInfo.type == TYPE_PUBLIC_KEY_CREDENTIAL ||
requestDisplayInfo.type == TYPE_PASSWORD_CREDENTIAL) {
Text(
text = requestDisplayInfo.title,
style = MaterialTheme.typography.titleLarge,
modifier = Modifier.padding(top = 16.dp)
)
Text(
text = requestDisplayInfo.subtitle,
style = MaterialTheme.typography.bodyMedium,
modifier = Modifier.padding(bottom = 16.dp)
)
} else {
Text(
text = requestDisplayInfo.title,
style = MaterialTheme.typography.titleLarge,
modifier = Modifier.padding(top = 16.dp, bottom = 16.dp)
)
when (requestDisplayInfo.type) {
TYPE_PUBLIC_KEY_CREDENTIAL -> {
Text(
text = requestDisplayInfo.title,
style = MaterialTheme.typography.titleLarge,
modifier = Modifier.padding(top = 16.dp)
)
Text(
text = if (requestDisplayInfo.subtitle != null) {
stringResource(
R.string.passkey_before_subtitle) + " - " + requestDisplayInfo.subtitle
} else {stringResource(R.string.passkey_before_subtitle)},
style = MaterialTheme.typography.bodyMedium,
modifier = Modifier.padding(bottom = 16.dp)
)
}
TYPE_PASSWORD_CREDENTIAL -> {
Text(
text = requestDisplayInfo.title,
style = MaterialTheme.typography.titleLarge,
modifier = Modifier.padding(top = 16.dp)
)
Text(
// This subtitle would never be null for create password
text = requestDisplayInfo.subtitle ?: "",
style = MaterialTheme.typography.bodyMedium,
modifier = Modifier.padding(bottom = 16.dp)
)
}
else -> {
Text(
text = requestDisplayInfo.title,
style = MaterialTheme.typography.titleLarge,
modifier = Modifier.padding(top = 16.dp, bottom = 16.dp)
)
}
}
}
}

View File

@@ -73,7 +73,7 @@ class RemoteInfo(
data class RequestDisplayInfo(
val title: String,
val subtitle: String,
val subtitle: String?,
val type: String,
val appDomainName: String,
val typeIcon: Drawable,