Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix IME flicker to home screen w/ orientation change

Browse Source 
In [1] we attempted to updateImeParent() onConfigurationChange(),
computeImeParent() can pick a parent that didnt even request IME.
This can cause flicker when going from app to launcher.

Adding a check for prevents this from happening.

Fix: 188864578
Test: atest DisplayContentTests

Change-Id: I01b67b9a7fdf04f23ab05c244281f42518352ca5
This commit is contained in:
Taran Singh
2021-05-21 19:19:12 +00:00
parent 13bd292dd5
commit e31d74b116
2 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/core/java/com/android/server/wm/DisplayContent.java
View File

@@ -3963,6 +3963,10 @@ class DisplayContent extends RootDisplayArea implements WindowManagerPolicy.Disp
// screen. If it's not covering the entire screen the IME might extend beyond the apps
// bounds.
if (allowAttachToApp && shouldImeAttachedToApp()) {
if (mImeLayeringTarget.mActivityRecord != mImeInputTarget.mActivityRecord) {
// Do not change parent if the window hasn't requested IME.
return null;
}
return mImeLayeringTarget.mActivityRecord.getSurfaceControl();
}

16
services/tests/wmtests/src/com/android/server/wm/DisplayContentTests.java
View File

@@ -357,6 +357,22 @@ public class DisplayContentTests extends WindowTestsBase {
verify(imeContainer).assignRelativeLayer(any(), eq(imeSurfaceParent), anyInt(), eq(true));
}
@Test
public void testComputeImeTargetReturnsNull_windowDidntRequestIme() {
final WindowState win1 = createWindow(null, TYPE_BASE_APPLICATION,
new ActivityBuilder(mAtm).setCreateTask(true).build(), "app");
final WindowState win2 = createWindow(null, TYPE_BASE_APPLICATION,
new ActivityBuilder(mAtm).setCreateTask(true).build(), "app2");
mDisplayContent.setImeInputTarget(win1);
mDisplayContent.setImeLayeringTarget(win2);
doReturn(true).when(mDisplayContent).shouldImeAttachedToApp();
// Compute IME parent returns nothing if current target and window receiving input
// are different i.e. if current window didn't request IME.
assertNull("computeImeParent() should be null", mDisplayContent.computeImeParent());
}
/**
* This tests root task movement between displays and proper root task's, task's and app token's
* display container references updates.