Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes flaky tests

Browse Source 
The CountDownLatch should be put at the last line to avoid making
CountDownLatch#await passed without updating values.

Bug: 224717753
Test: atest WindowMagnificationControllerTest
Change-Id: I29530a02780291d684a30e31b4811f2b95fe0faf
This commit is contained in:
Daniel Hsieh
2022-04-19 06:07:50 +00:00
parent 1b43c023fa
commit dfff81e489
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/SystemUI/tests/src/com/android/systemui/accessibility/MockMagnificationAnimationCallback.java
View File

@@ -44,11 +44,13 @@ public class MockMagnificationAnimationCallback extends IRemoteMagnificationAnim
@Override
public void onResult(boolean success) throws RemoteException {
mCountDownLatch.countDown();
if (success) {
mSuccessCount.getAndIncrement();
} else {
mFailedCount.getAndIncrement();
}
// It should be put at the last line to avoid making CountDownLatch#await passed without
// updating values.
mCountDownLatch.countDown();
}
}

3
packages/SystemUI/tests/src/com/android/systemui/accessibility/WindowMagnificationControllerTest.java
View File

@@ -80,7 +80,6 @@ import com.android.systemui.utils.os.FakeHandler;
import org.junit.After;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Answers;
@@ -319,7 +318,6 @@ public class WindowMagnificationControllerTest extends SysuiTestCase {
verify(mSfVsyncFrameProvider, atLeastOnce()).postFrameCallback(any());
}
@Ignore("b/224717753")
@Test
public void moveWindowMagnifierToPositionWithAnimation_expectedValuesAndInvokeCallback()
throws InterruptedException {
@@ -354,7 +352,6 @@ public class WindowMagnificationControllerTest extends SysuiTestCase {
assertEquals(mWindowMagnificationController.getCenterY(), targetCenterY, 0);
}
@Ignore("b/224717753")
@Test
public void moveWindowMagnifierToPositionMultipleTimes_expectedValuesAndInvokeCallback()
throws InterruptedException {