Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some RollbackManagerInternal cleanup (7/n)

Browse Source 
As of ag/10689533, RollbackManagerInternal is a local service which will
not throw runtime exceptions. Let's remove unused try/catch blocks.

Bug: 150347230
Test: atest RollbackTest StagedRollbackTest
Change-Id: Ifde3e7dd2bd97abde27854a57b55b42b3e30799b
This commit is contained in:
JW Wang
2020-06-09 13:59:04 +08:00
parent d213fa18fd
commit de8be88614
2 changed files with 7 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
services/core/java/com/android/server/pm/PackageManagerService.java
View File

@@ -14464,13 +14464,8 @@ public class PackageManagerService extends IPackageManager.Stub
if (ps != null && doSnapshotOrRestore) {
final String seInfo = AndroidPackageUtils.getSeInfo(res.pkg, ps);
try {
rm.snapshotAndRestoreUserData(packageName, UserHandle.toUserHandles(installedUsers),
appId, ceDataInode, seInfo, token);
} catch (RuntimeException re) {
Log.e(TAG, "Error snapshotting/restoring user data: " + re);
return false;
}
rm.snapshotAndRestoreUserData(packageName, UserHandle.toUserHandles(installedUsers),
appId, ceDataInode, seInfo, token);
return true;
}
return false;

18
services/core/java/com/android/server/pm/StagingManager.java
View File

@@ -521,13 +521,9 @@ public class StagingManager {
private void snapshotAndRestoreApexUserData(
String packageName, int[] allUsers, RollbackManagerInternal rm) {
try {
// appId, ceDataInode, and seInfo are not needed for APEXes
rm.snapshotAndRestoreUserData(packageName, UserHandle.toUserHandles(allUsers), 0, 0,
null, 0 /*token*/);
} catch (RuntimeException re) {
Slog.e(TAG, "Error snapshotting/restoring user data: " + re);
}
// appId, ceDataInode, and seInfo are not needed for APEXes
rm.snapshotAndRestoreUserData(packageName, UserHandle.toUserHandles(allUsers), 0, 0,
null, 0 /*token*/);
}
private void snapshotAndRestoreApkInApexUserData(
@@ -551,12 +547,8 @@ public class StagingManager {
final int[] installedUsers = ps.queryInstalledUsers(allUsers, true);
final String seInfo = AndroidPackageUtils.getSeInfo(pkg, ps);
try {
rm.snapshotAndRestoreUserData(packageName, UserHandle.toUserHandles(installedUsers),
appId, ceDataInode, seInfo, 0 /*token*/);
} catch (RuntimeException re) {
Slog.e(TAG, "Error snapshotting/restoring user data: " + re);
}
rm.snapshotAndRestoreUserData(packageName, UserHandle.toUserHandles(installedUsers),
appId, ceDataInode, seInfo, 0 /*token*/);
}
}