Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Changed onGetScores() to return null instead of throwing exception."

Browse Source
This commit is contained in:
TreeHugger Robot
2018-01-22 22:46:22 +00:00
committed by Android (Google) Code Review
parent 1776fa33f1 029f10100c
commit de6d13f857
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/java/android/service/autofill/AutofillFieldClassificationService.java
View File

@@ -99,7 +99,9 @@ public abstract class AutofillFieldClassificationService extends Service {
final String[] userDataValues = (String[]) args.arg5;
final float[][] scores = onGetScores(algorithmName, algorithmArgs, actualValues,
Arrays.asList(userDataValues));
data.putParcelable(EXTRA_SCORES, new Scores(scores));
if (scores != null) {
data.putParcelable(EXTRA_SCORES, new Scores(scores));
}
break;
default:
Log.w(TAG, "Handling unknown message: " + action);
@@ -148,7 +150,8 @@ public abstract class AutofillFieldClassificationService extends Service {
public float[][] onGetScores(@Nullable String algorithm,
@Nullable Bundle args, @NonNull List<AutofillValue> actualValues,
@NonNull List<String> userDataValues) {
throw new UnsupportedOperationException("Must be implemented by external service");
Log.e(TAG, "service implementation (" + getClass() + " does not implement onGetScore()");
return null;
}
private final class AutofillFieldClassificationServiceWrapper
@@ -182,7 +185,7 @@ public abstract class AutofillFieldClassificationService extends Service {
}
}
private Scores(float[][] scores) {
private Scores(float[][] scores) {
this.scores = scores;
}