Merge "Add additional logging for EMBMS edge cases"

This commit is contained in:
Hall Liu
2018-03-28 22:25:44 +00:00
committed by Gerrit Code Review
2 changed files with 7 additions and 3 deletions

View File

@@ -920,11 +920,11 @@ public class MbmsDownloadSession implements AutoCloseable {
try {
if (!token.createNewFile()) {
throw new RuntimeException("Failed to create download token for request "
+ request);
+ request + ". Token location is " + token.getPath());
}
} catch (IOException e) {
throw new RuntimeException("Failed to create download token for request " + request
+ " due to IOException " + e);
+ " due to IOException " + e + ". Attempted to write to " + token.getPath());
}
}

View File

@@ -297,7 +297,9 @@ public class MbmsDownloadReceiver extends BroadcastReceiver {
for (Uri tempFileUri : tempFiles) {
if (verifyTempFilePath(context, request.getFileServiceId(), tempFileUri)) {
File tempFile = new File(tempFileUri.getSchemeSpecificPart());
tempFile.delete();
if (!tempFile.delete()) {
Log.w(LOG_TAG, "Failed to delete temp file at " + tempFile.getPath());
}
}
}
}
@@ -474,6 +476,8 @@ public class MbmsDownloadReceiver extends BroadcastReceiver {
if (!MbmsUtils.isContainedIn(
MbmsUtils.getEmbmsTempFileDirForService(context, serviceId), tempFile)) {
Log.w(LOG_TAG, "File at " + path + " is not contained in the temp file root," +
" which is " + MbmsUtils.getEmbmsTempFileDirForService(context, serviceId));
return false;
}