Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove allocation from HeaderTileLayout#onLayout

Browse Source 
Moved allocation of Rect to construction, and only bounds are modified
on layout.

Also fixed typo

Test: visual, expanding animation on large display
Fixes: 131093881
Change-Id: I92e14deee73820c5c21d7328d6a84b3115bb3c1f
This commit is contained in:
Fabian Kozynski
2019-04-22 14:30:59 -04:00
parent 18184f9c86
commit dc23ef66d9
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/SystemUI/src/com/android/systemui/qs/QuickQSPanel.java
View File

@@ -181,6 +181,7 @@ public class QuickQSPanel extends QSPanel {
private static class HeaderTileLayout extends TileLayout {
private boolean mListening;
private Rect mClippingBounds = new Rect();
public HeaderTileLayout(Context context) {
super(context);
@@ -219,8 +220,8 @@ public class QuickQSPanel extends QSPanel {
@Override
protected void onLayout(boolean changed, int l, int t, int r, int b) {
// We only care about clipping on the right side
Rect bounds = new Rect(0, 0, r - l, 10000);
setClipBounds(bounds);
mClippingBounds.set(0, 0, r - l, 10000);
setClipBounds(mClippingBounds);
calculateColumns();
@@ -252,9 +253,9 @@ public class QuickQSPanel extends QSPanel {
}
final int availableWidth = getMeasuredWidth() - getPaddingStart() - getPaddingEnd();
final int leftoverWithespace = availableWidth - maxTiles * mCellWidth;
final int leftoverWhitespace = availableWidth - maxTiles * mCellWidth;
final int smallestHorizontalMarginNeeded;
smallestHorizontalMarginNeeded = leftoverWithespace / Math.max(1, maxTiles - 1);
smallestHorizontalMarginNeeded = leftoverWhitespace / Math.max(1, maxTiles - 1);
if (smallestHorizontalMarginNeeded > 0){
mCellMarginHorizontal = smallestHorizontalMarginNeeded;