Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix toggle QS tiles don't respond when One-handed mode triggered

Browse Source 
Previous ag/17896369 missed the OHM edge case, when OHM
activated, the ev.getX(), ev.getY() has been count in OHM
offset, using ev.getRawX() & ev.getRawY() would mis-leading
the QQS tile location while OHM translate down DisplayArea.

1. Set x and y offset for mQsHeaderBound when OHM activated
2. Fix broken NotificationStackScrollLayoutTest

Bug: 233033336
Bug: 232901446

Test: manually check notificaiton panel when entering One-handed mode
Test: manually test the QS/QQS functionality works in landscape
Test: atest SystemUITests
Test: atest NotificationStackScrollLayoutTest
Change-Id: I8be7ba86fee52f19bac2733661c8616528a705be
This commit is contained in:
Jason Chang
2022-05-20 17:55:21 +08:00
parent 9dd35d01f8
commit dbb7725436
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/SystemUI/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayout.java
View File

@@ -3642,6 +3642,18 @@ public class NotificationStackScrollLayout extends ViewGroup implements Dumpable
@ShadeViewRefactor(RefactorComponent.INPUT)
protected boolean isInsideQsHeader(MotionEvent ev) {
mQsHeader.getBoundsOnScreen(mQsHeaderBound);
/**
* One-handed mode defines a feature FEATURE_ONE_HANDED of DisplayArea {@link DisplayArea}
* that will translate down the Y-coordinate whole window screen type except for
* TYPE_NAVIGATION_BAR and TYPE_NAVIGATION_BAR_PANEL .{@link DisplayAreaPolicy}.
*
* So, to consider triggered One-handed mode would translate down the absolute Y-coordinate
* of DisplayArea into relative coordinates for all windows, we need to correct the
* QS Head bounds here.
*/
final int xOffset = Math.round(ev.getRawX() - ev.getX());
final int yOffset = Math.round(ev.getRawY() - ev.getY());
mQsHeaderBound.offsetTo(xOffset, yOffset);
return mQsHeaderBound.contains((int) ev.getRawX(), (int) ev.getRawY());
}

4
packages/SystemUI/tests/src/com/android/systemui/statusbar/notification/stack/NotificationStackScrollLayoutTest.java
View File

@@ -608,10 +608,10 @@ public class NotificationStackScrollLayoutTest extends SysuiTestCase {
assertFalse(mStackScroller.isInsideQsHeader(event1));
MotionEvent event2 = transformEventForView(createMotionEvent(150f, 150f), mStackScroller);
assertTrue(mStackScroller.isInsideQsHeader(event2));
assertFalse(mStackScroller.isInsideQsHeader(event2));
MotionEvent event3 = transformEventForView(createMotionEvent(250f, 250f), mStackScroller);
assertTrue(mStackScroller.isInsideQsHeader(event2));
assertTrue(mStackScroller.isInsideQsHeader(event3));
}
@Test