Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Guide towards Context.createPackageContextAsUser()."

Browse Source
This commit is contained in:
Jeff Sharkey
2018-11-28 16:08:36 +00:00
committed by Android (Google) Code Review
parent c583071b97 86445841ac
commit d7aabe2b9a
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tools/apilint/apilint.py
View File

@@ -1285,10 +1285,19 @@ def verify_user_handle(clazz):
if clazz.fullname == "android.os.UserManager": return
for m in clazz.methods:
if m.name.endswith("AsUser") or m.name.endswith("ForUser"): continue
if re.match("on[A-Z]+", m.name): continue
if "android.os.UserHandle" in m.args:
warn(clazz, m, None, "Method taking UserHandle should be named 'doFooAsUser' or 'queryFooForUser'")
has_arg = "android.os.UserHandle" in m.args
has_name = m.name.endswith("AsUser") or m.name.endswith("ForUser")
if clazz.fullname.endswith("Manager") and has_arg:
warn(clazz, m, None, "When a method overload is needed to target a specific "
"UserHandle, callers should be directed to use "
"Context.createPackageContextAsUser() and re-obtain the relevant "
"Manager, and no new API should be added")
elif has_arg and not has_name:
warn(clazz, m, None, "Method taking UserHandle should be named 'doFooAsUser' "
"or 'queryFooForUser'")
def verify_params(clazz):