Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix recent checkPermission() bug.

Browse Source 
It should be checking if the UID argument passed in has the requested
permission; not the calling UID.

Test: builds, boots
Bug: 34528367
Change-Id: Ie1828f571d9f143ce9f5bdca2eedcf2fa6ccfd79
This commit is contained in:
Jeff Sharkey
2017-01-23 11:37:24 -07:00
parent dbb1176b49
commit d69b083bc3
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
core/java/android/app/ContextImpl.java
View File

@@ -1591,12 +1591,15 @@ class ContextImpl extends Context {
}
final IActivityManager am = ActivityManager.getService();
if (am == null && UserHandle.getAppId(Binder.getCallingUid()) == Process.SYSTEM_UID) {
if (am == null) {
// Well this is super awkward; we somehow don't have an active
// ActivityManager instance. If this is the system UID, then we
// totally have whatever permission this is.
Slog.w(TAG, "Missing ActivityManager; assuming system UID holds " + permission);
return PackageManager.PERMISSION_GRANTED;
// ActivityManager instance. If we're testing a root or system
// UID, then they totally have whatever permission this is.
final int appId = UserHandle.getAppId(uid);
if (appId == Process.ROOT_UID || appId == Process.SYSTEM_UID) {
Slog.w(TAG, "Missing ActivityManager; assuming " + uid + " holds " + permission);
return PackageManager.PERMISSION_GRANTED;
}
}
try {