Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecate setVisualVoicemailEnabled isVisualVoicemailEnabled

Browse Source 
The visual voicemail client is removed from telephony service. There
are no longer code to handle these methods. These methods are only
used by dialer during NMR1.

Bug: 36173451
Fixes: 36173451

Test: smoke test dialer visual voicemail operations.
Change-Id: I82a35026821b4c4d98420e5bfcecff78b2163822
This commit is contained in:
Ta-wei Yen
2017-04-03 18:13:20 -07:00
parent 64b214ea16
commit d6099178f1
3 changed files with 7 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api/system-current.txt
View File

@@ -43400,7 +43400,7 @@ package android.telephony {
method public boolean isSmsCapable();
method public boolean isTtyModeSupported();
method public boolean isVideoCallingEnabled();
method public boolean isVisualVoicemailEnabled(android.telecom.PhoneAccountHandle);
method public deprecated boolean isVisualVoicemailEnabled(android.telecom.PhoneAccountHandle);
method public boolean isVoiceCapable();
method public boolean isVoicemailVibrationEnabled(android.telecom.PhoneAccountHandle);
method public boolean isWorldPhone();
@@ -43418,7 +43418,7 @@ package android.telephony {
method public boolean setPreferredNetworkTypeToGlobal();
method public boolean setRadio(boolean);
method public boolean setRadioPower(boolean);
method public void setVisualVoicemailEnabled(android.telecom.PhoneAccountHandle, boolean);
method public deprecated void setVisualVoicemailEnabled(android.telecom.PhoneAccountHandle, boolean);
method public boolean setVoiceMailNumber(java.lang.String, java.lang.String);
method public void setVoicemailRingtoneUri(android.telecom.PhoneAccountHandle, android.net.Uri);
method public void setVoicemailVibrationEnabled(android.telecom.PhoneAccountHandle, boolean);

25
telephony/java/android/telephony/TelephonyManager.java
View File

@@ -2706,19 +2706,12 @@ public class TelephonyManager {
* @param phoneAccountHandle the phone account to change the client state
* @param enabled the new state of the client
* @hide
* @deprecated Visual voicemail no longer in telephony. {@link VisualVoicemailService} should
* be implemented instead.
*/
@SystemApi
public void setVisualVoicemailEnabled(PhoneAccountHandle phoneAccountHandle, boolean enabled){
try {
ITelephony telephony = getITelephony();
if (telephony != null) {
telephony.setVisualVoicemailEnabled(mContext.getOpPackageName(), phoneAccountHandle,
enabled);
}
} catch (RemoteException ex) {
} catch (NullPointerException ex) {
// This could happen before phone restarts due to crashing
}
}
/**
@@ -2730,19 +2723,11 @@ public class TelephonyManager {
* @param phoneAccountHandle the phone account to check for.
* @return {@code true} when the visual voicemail client is enabled for this client
* @hide
* @deprecated Visual voicemail no longer in telephony. {@link VisualVoicemailService} should
* be implemented instead.
*/
@SystemApi
public boolean isVisualVoicemailEnabled(PhoneAccountHandle phoneAccountHandle){
try {
ITelephony telephony = getITelephony();
if (telephony != null) {
return telephony.isVisualVoicemailEnabled(
mContext.getOpPackageName(), phoneAccountHandle);
}
} catch (RemoteException ex) {
} catch (NullPointerException ex) {
// This could happen before phone restarts due to crashing
}
return false;
}

6
telephony/java/com/android/internal/telephony/ITelephony.aidl
View File

@@ -498,12 +498,6 @@ interface ITelephony {
*/
boolean isConcurrentVoiceAndDataAllowed(int subId);
oneway void setVisualVoicemailEnabled(String callingPackage,
in PhoneAccountHandle accountHandle, boolean enabled);
boolean isVisualVoicemailEnabled(String callingPackage,
in PhoneAccountHandle accountHandle);
String getVisualVoicemailPackageName(String callingPackage, int subId);
// Not oneway, caller needs to make sure the vaule is set before receiving a SMS