Fix crash in Vulkan pipeline at boot time

Fix a crash caused by calling OpenGL APIs with Vulkan pipeline
(likely a regression from ag/2706458).

Test: Ran CtsViewTestCases tests with SkiaGL pipeline.
Change-Id: Ibabeb4229ef88de57c99f2961a10a68ca71b25ab
This commit is contained in:
Stan Iliev
2017-10-18 13:12:32 -04:00
parent 3cf1a94524
commit d56d2188fc
2 changed files with 7 additions and 1 deletions

View File

@@ -31,6 +31,12 @@ namespace android {
namespace uirenderer {
Extensions::Extensions() {
if (Properties::getRenderPipelineType() != RenderPipelineType::OpenGL) {
//Extensions class is used only by OpenGL pipeline
//The code below will crash for SkiaVulkan, because OpenGL is not initialized
//TODO: instantiate Extensions class only for OpenGL pipeline
return;
}
const char* version = (const char*) glGetString(GL_VERSION);
// Section 6.1.5 of the OpenGL ES specification indicates the GL version

View File

@@ -73,7 +73,7 @@ CopyResult SkiaOpenGLReadback::copyImageInto(EGLImageKHR eglImage, const Matrix4
* for reading back float buffers (skbug.com/6945).
*/
if (pixelConfig == kRGBA_half_GrPixelConfig &&
!DeviceInfo::get()->extensions().hasFloatTextures()) {
!grContext->caps()->isConfigTexturable(kRGBA_half_GrPixelConfig)) {
ALOGW("Can't copy surface into bitmap, RGBA_F16 config is not supported");
return CopyResult::DestinationInvalid;
}