Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix google-explicit-constructor warnings.

Browse Source 
Bug: 28341362
Change-Id: I080090d50f1a368a4e7c1a0732297bb6a295e34f
This commit is contained in:
Chih-Hung Hsieh
2016-05-03 10:02:51 -07:00
parent 5b93c24bc0
commit d53e3bed1c
14 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/jni/android_view_ThreadedRenderer.cpp
View File

@@ -80,7 +80,7 @@ void onRenderNodeRemoved(JNIEnv* env, RenderNode* node);
class ScopedRemovedRenderNodeObserver : public TreeObserver {
public:
ScopedRemovedRenderNodeObserver(JNIEnv* env) : mEnv(env) {}
explicit ScopedRemovedRenderNodeObserver(JNIEnv* env) : mEnv(env) {}
~ScopedRemovedRenderNodeObserver() {
for (auto& node : mMaybeRemovedNodes) {
if (node->hasParents()) continue;

2
libs/hwui/renderthread/CanvasContext.cpp
View File

@@ -762,7 +762,7 @@ void CanvasContext::waitOnFences() {
class CanvasContext::FuncTaskProcessor : public TaskProcessor<bool> {
public:
FuncTaskProcessor(Caches& caches)
explicit FuncTaskProcessor(Caches& caches)
: TaskProcessor<bool>(&caches.tasks) {}
virtual void onProcess(const sp<Task<bool> >& task) override {

2
libs/hwui/tests/macrobench/TestSceneRunner.cpp
View File

@@ -41,7 +41,7 @@ public:
template<class T>
class ModifiedMovingAverage {
public:
ModifiedMovingAverage(int weight) : mWeight(weight) {}
explicit ModifiedMovingAverage(int weight) : mWeight(weight) {}
T add(T today) {
if (!mHasValue) {

2
libs/hwui/tests/microbench/TaskManagerBench.cpp
View File

@@ -29,7 +29,7 @@ class TrivialTask : public Task<char> {};
class TrivialProcessor : public TaskProcessor<char> {
public:
TrivialProcessor(TaskManager* manager)
explicit TrivialProcessor(TaskManager* manager)
: TaskProcessor(manager) {}
virtual ~TrivialProcessor() {}
virtual void onProcess(const sp<Task<char> >& task) override {

4
libs/hwui/tests/unit/FrameBuilderTests.cpp
View File

@@ -1919,7 +1919,7 @@ static void testProperty(std::function<void(RenderProperties&)> propSetupCallbac
std::function<void(const RectOp&, const BakedOpState&)> opValidateCallback) {
class PropertyTestRenderer : public TestRendererBase {
public:
PropertyTestRenderer(std::function<void(const RectOp&, const BakedOpState&)> callback)
explicit PropertyTestRenderer(std::function<void(const RectOp&, const BakedOpState&)> callback)
: mCallback(callback) {}
void onRectOp(const RectOp& op, const BakedOpState& state) override {
EXPECT_EQ(mIndex++, 0);
@@ -2040,7 +2040,7 @@ void testSaveLayerAlphaClip(SaveLayerAlphaData* outObservedData,
std::function<void(RenderProperties&)> propSetupCallback) {
class SaveLayerAlphaClipTestRenderer : public TestRendererBase {
public:
SaveLayerAlphaClipTestRenderer(SaveLayerAlphaData* outData)
explicit SaveLayerAlphaClipTestRenderer(SaveLayerAlphaData* outData)
: mOutData(outData) {}
OffscreenBuffer* startTemporaryLayer(uint32_t width, uint32_t height) override {

2
libs/hwui/tests/unit/RenderNodeTests.cpp
View File

@@ -55,7 +55,7 @@ TEST(RenderNode, hasParents) {
TEST(RenderNode, releasedCallback) {
class DecRefOnReleased : public GlFunctorLifecycleListener {
public:
DecRefOnReleased(int* refcnt) : mRefCnt(refcnt) {}
explicit DecRefOnReleased(int* refcnt) : mRefCnt(refcnt) {}
void onGlFunctorReleased(Functor* functor) override {
*mRefCnt -= 1;
}

2
libs/hwui/utils/TestWindowContext.cpp
View File

@@ -58,7 +58,7 @@ class TestWindowContext::TestWindowData {
public:
TestWindowData(SkISize size) : mSize(size) {
explicit TestWindowData(SkISize size) : mSize(size) {
android::BufferQueue::createBufferQueue(&mProducer, &mConsumer);
mCpuConsumer = new android::CpuConsumer(mConsumer, 1);
mCpuConsumer->setName(android::String8("TestWindowContext"));

4
services/tests/servicestests/jni/apf_jni.cpp
View File

@@ -39,7 +39,7 @@ static jint com_android_server_ApfTest_apfSimulate(
class ScopedPcap {
public:
ScopedPcap(pcap_t* pcap) : pcap_ptr(pcap) {}
explicit ScopedPcap(pcap_t* pcap) : pcap_ptr(pcap) {}
~ScopedPcap() {
pcap_close(pcap_ptr);
}
@@ -51,7 +51,7 @@ class ScopedPcap {
class ScopedFILE {
public:
ScopedFILE(FILE* fp) : file(fp) {}
explicit ScopedFILE(FILE* fp) : file(fp) {}
~ScopedFILE() {
fclose(file);
}

2
tools/aapt/Command.cpp
View File

@@ -494,7 +494,7 @@ struct ImpliedFeature {
struct Feature {
Feature() : required(false), version(-1) {}
Feature(bool required, int32_t version = -1) : required(required), version(version) {}
explicit Feature(bool required, int32_t version = -1) : required(required), version(version) {}
/**
* Whether the feature is required.

2
tools/aapt2/compile/XmlIdCollector.cpp
View File

@@ -35,7 +35,7 @@ struct IdCollector : public xml::Visitor {
std::vector<SourcedResourceName>* mOutSymbols;
IdCollector(std::vector<SourcedResourceName>* outSymbols) : mOutSymbols(outSymbols) {
explicit IdCollector(std::vector<SourcedResourceName>* outSymbols) : mOutSymbols(outSymbols) {
}
void visit(xml::Element* element) override {

2
tools/aapt2/link/ManifestFixer.cpp
View File

@@ -220,7 +220,7 @@ class FullyQualifiedClassNameVisitor : public xml::Visitor {
public:
using xml::Visitor::visit;
FullyQualifiedClassNameVisitor(const StringPiece16& package) : mPackage(package) {
explicit FullyQualifiedClassNameVisitor(const StringPiece16& package) : mPackage(package) {
}
void visit(xml::Element* el) override {

2
tools/aapt2/proto/TableProtoDeserializer.cpp
View File

@@ -30,7 +30,7 @@ class ReferenceIdToNameVisitor : public ValueVisitor {
public:
using ValueVisitor::visit;
ReferenceIdToNameVisitor(const std::map<ResourceId, ResourceNameRef>* mapping) :
explicit ReferenceIdToNameVisitor(const std::map<ResourceId, ResourceNameRef>* mapping) :
mMapping(mapping) {
assert(mMapping);
}

2
tools/aapt2/split/TableSplitter.cpp
View File

@@ -40,7 +40,7 @@ static ConfigDescription copyWithoutDensity(const ConfigDescription& config) {
*/
class SplitValueSelector {
public:
SplitValueSelector(const SplitConstraints& constraints) {
explicit SplitValueSelector(const SplitConstraints& constraints) {
for (const ConfigDescription& config : constraints.configs) {
if (config.density == 0) {
mDensityIndependentConfigs.insert(config);

2
tools/aapt2/unflatten/BinaryResourceParser.cpp
View File

@@ -47,7 +47,7 @@ private:
public:
using ValueVisitor::visit;
ReferenceIdToNameVisitor(const std::map<ResourceId, ResourceName>* mapping) :
explicit ReferenceIdToNameVisitor(const std::map<ResourceId, ResourceName>* mapping) :
mMapping(mapping) {
assert(mMapping);
}