Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Change default showClockAndComplications to false."

Browse Source 
This reverts commit ae8b96964c.

Reason for revert: causes overlay elements to not appear.

Test: manual
Bug: 222307681
Change-Id: I2d1f55227774a39f4b2dbe927ddd3aa1a5178351
This commit is contained in:
Bryce Lee
2022-03-02 21:17:05 +00:00
parent f197339ea8
commit d3f2dc954f
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
core/java/android/service/dreams/DreamService.java
View File

@@ -231,7 +231,7 @@ public class DreamService extends Service implements Window.Callback {
* The default value for whether to show complications on the overlay.
* @hide
*/
public static final boolean DEFAULT_SHOW_COMPLICATIONS = false;
public static final boolean DEFAULT_SHOW_COMPLICATIONS = true;
private final IDreamManager mDreamManager;
private final Handler mHandler = new Handler(Looper.getMainLooper());

8
packages/SystemUI/tests/src/com/android/systemui/dreams/DreamOverlayServiceTest.java
View File

@@ -173,19 +173,19 @@ public class DreamOverlayServiceTest extends SysuiTestCase {
}
@Test
public void testShouldShowComplicationsFalseByDefault() {
public void testShouldShowComplicationsTrueByDefault() {
mService.onBind(new Intent());
assertThat(mService.shouldShowComplications()).isFalse();
assertThat(mService.shouldShowComplications()).isTrue();
}
@Test
public void testShouldShowComplicationsSetByIntentExtra() {
final Intent intent = new Intent();
intent.putExtra(DreamService.EXTRA_SHOW_COMPLICATIONS, true);
intent.putExtra(DreamService.EXTRA_SHOW_COMPLICATIONS, false);
mService.onBind(intent);
assertThat(mService.shouldShowComplications()).isTrue();
assertThat(mService.shouldShowComplications()).isFalse();
}
@Test

1
packages/SystemUI/tests/src/com/android/systemui/dreams/DreamOverlayStateControllerTest.java
View File

@@ -158,7 +158,6 @@ public class DreamOverlayStateControllerTest extends SysuiTestCase {
public void testComplicationFilteringWhenShouldShowComplications() {
final DreamOverlayStateController stateController =
new DreamOverlayStateController(mExecutor);
stateController.setShouldShowComplications(true);
final Complication alwaysAvailableComplication = Mockito.mock(Complication.class);
final Complication weatherComplication = Mockito.mock(Complication.class);